Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2639833003: MD Settings: Apply guest changes to public accounts (Closed)

Created:
3 years, 11 months ago by michaelpg
Modified:
3 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Apply guest changes to public accounts Simple change to make public account sessions hide some Settings features the same way guest mode sessions do. BUG=682107 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2639833003 Cr-Commit-Position: refs/heads/master@{#444483} Committed: https://chromium.googlesource.com/chromium/src/+/17b8c228ff69ac6dd875eac2bf81c0a96eb32c1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
michaelpg
3 years, 11 months ago (2017-01-18 04:54:41 UTC) #1
stevenjb
lgtm
3 years, 11 months ago (2017-01-18 18:40:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639833003/1
3 years, 11 months ago (2017-01-18 21:12:25 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 21:19:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17b8c228ff69ac6dd875eac2bf81...

Powered by Google App Engine
This is Rietveld 408576698