--method-blocklist should also cover free functions.

--method-blocklist should also cover free functions.

One example where this is needed is blink::DOMWindowTimers which:
1. implements WindowTimers.idl and
2. is a namespace containing free functions
   (not a class containing static methods).

BUG=673039
Review-Url: https://codereview.chromium.org/2639813002
Cr-Commit-Position: refs/heads/master@{#444599}
Committed: https://chromium.googlesource.com/chromium/src/+/694194cd5bd8e7ced0c59eac109f0033aa7e1f30

[Łukasz Anforowicz, 2017-01-18 00:23:53]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-01-18 00:23:54]

Daniel, can you PTAL?

[dcheng, 2017-01-19 00:14:25]

It's not possible to have namespaces and classes collide, right?

[dcheng, 2017-01-19 00:14:52]

(Also, LGTM)

[Łukasz Anforowicz, 2017-01-19 00:21:50]

On 2017/01/19 00:14:25, dcheng wrote:
> It's not possible to have namespaces and classes collide, right?

I don't know.  FWIW, Stack Overflow says that it is not possible:
http://stackoverflow.com/questions/5856759/can-a-class-share-a-namespaces-name. 
At any rate, I hope that GetContextDecl() would do the right thing if such a
situation was allowed.

[Łukasz Anforowicz, 2017-01-19 00:22:35]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:58:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484785355584750, "parent_rev":
"6936c67f34dfe72954dd522f16f2dfa9c600da84", "commit_rev":
"694194cd5bd8e7ced0c59eac109f0033aa7e1f30"}

[commit-bot: I haz the power, 2017-01-19 01:59:08]

Description was changed from

==========
--method-blocklist should also cover free functions.

One example where this is needed is blink::DOMWindowTimers which:
1. implements WindowTimers.idl and
2. is a namespace containing free functions
   (not a class containing static methods).

BUG=673039
==========

to

==========
--method-blocklist should also cover free functions.

One example where this is needed is blink::DOMWindowTimers which:
1. implements WindowTimers.idl and
2. is a namespace containing free functions
   (not a class containing static methods).

BUG=673039

Review-Url: https://codereview.chromium.org/2639813002
Cr-Commit-Position: refs/heads/master@{#444599}
Committed:
https://chromium.googlesource.com/chromium/src/+/694194cd5bd8e7ced0c59eac109f...
==========

[commit-bot: I haz the power, 2017-01-19 01:59:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/694194cd5bd8e7ced0c59eac109f...