Stop triggering context menu while scrolling

Stop triggering context menu while scrolling

Context menu should not be triggered while scrolling, as some users
tend to stop scrolling by resting the finger on the screen instead of
touching the screen.

BUG=642375
Review-Url: https://codereview.chromium.org/2639793002
Cr-Commit-Position: refs/heads/master@{#444212}
Committed: https://chromium.googlesource.com/chromium/src/+/536bc327cab4ce2d6ae1fa30d9fc9ccdfaed4d32

[liaoyuke, 2017-01-18 00:00:36]

liaoyuke@chromium.org changed reviewers:
+ eugenebut@chromium.org

[liaoyuke, 2017-01-18 00:00:37]

Hi Eugene,

Please take a look.

Thank you very much!

[liaoyuke, 2017-01-18 00:08:27]

The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:08:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-01-18 00:20:01]

lgtm. Please update CL description to fit 72 symbols width limit.

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_context_menu_controller.mm (right):

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:310: if ([self
webScrollView].isDragging) {
self.webScrollView.dragging

From Style Guide: "Dot notation is used only with property names, not with
method names."
go/objc-style?showone=Objective-C_Method_Names&cl=head#Objective-C_Method_Names

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:311: return false;
s/false/NO

[liaoyuke, 2017-01-18 00:23:59]

Description was changed from

==========
Stop triggering context menu while scrolling

Context menu should not be triggered while scrolling, as some users tend to stop
scrolling by resting the finger on the screen instead of touching the screen.

BUG=642375
==========

to

==========
Stop triggering context menu while scrolling

Context menu should not be triggered while scrolling, as some users
tend to stop scrolling by resting the finger on the screen instead of
touching the screen.

BUG=642375
==========

[liaoyuke, 2017-01-18 00:26:47]

Thank you for the careful review!

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_context_menu_controller.mm (right):

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:310: if ([self
webScrollView].isDragging) {
On 2017/01/18 00:20:00, Eugene But wrote:
> self.webScrollView.dragging
> 
> From Style Guide: "Dot notation is used only with property names, not with
> method names."
>
go/objc-style?showone=Objective-C_Method_Names&cl=head#Objective-C_Method_Names

Done.

https://codereview.chromium.org/2639793002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_context_menu_controller.mm:311: return false;
On 2017/01/18 00:20:00, Eugene But wrote:
> s/false/NO

Done.

[liaoyuke, 2017-01-18 00:29:08]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2017-01-18 00:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2639793002/#ps40001
(title: "Adressed feedback")

[commit-bot: I haz the power, 2017-01-18 00:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:55:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484699348454490,
"parent_rev": "0e34d34b9c9d949c73302fb4c64d5a5923adc3e4", "commit_rev":
"536bc327cab4ce2d6ae1fa30d9fc9ccdfaed4d32"}

[commit-bot: I haz the power, 2017-01-18 00:56:24]

Description was changed from

==========
Stop triggering context menu while scrolling

Context menu should not be triggered while scrolling, as some users
tend to stop scrolling by resting the finger on the screen instead of
touching the screen.

BUG=642375
==========

to

==========
Stop triggering context menu while scrolling

Context menu should not be triggered while scrolling, as some users
tend to stop scrolling by resting the finger on the screen instead of
touching the screen.

BUG=642375

Review-Url: https://codereview.chromium.org/2639793002
Cr-Commit-Position: refs/heads/master@{#444212}
Committed:
https://chromium.googlesource.com/chromium/src/+/536bc327cab4ce2d6ae1fa30d9fc...
==========

[commit-bot: I haz the power, 2017-01-18 00:56:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/536bc327cab4ce2d6ae1fa30d9fc...