Disable spawnFunction from dom enabled isolates

Disable spawnFunction from dom enabled isolates

R=asiva@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1423

[siva, 2013-10-08 23:46:32]

LGTM for now, we need to change the callback API to include an boolean.

https://chromiumcodereview.appspot.com/26397003/diff/1/Source/bindings/dart/D...
File Source/bindings/dart/DartController.cpp (right):

https://chromiumcodereview.appspot.com/26397003/diff/1/Source/bindings/dart/D...
Source/bindings/dart/DartController.cpp:357: // Hacky way to find out if it's
spawnFunction or isSpawnUri.
why does this comment have to change? spawnUri makes sense.

We should change the callback API to include a boolean (isSpawnUri).

This scheme of doing a string compare of the URIs won't work if somebody issues
a SpawnURI of the same URI because they want to load and execute a newer version
of the app in a new Isolate.

[vsm, 2013-10-09 04:48:35]

https://chromiumcodereview.appspot.com/26397003/diff/1/Source/bindings/dart/D...
File Source/bindings/dart/DartController.cpp (right):

https://chromiumcodereview.appspot.com/26397003/diff/1/Source/bindings/dart/D...
Source/bindings/dart/DartController.cpp:357: // Hacky way to find out if it's
spawnFunction or isSpawnUri.
On 2013/10/08 23:46:32, siva wrote:
> why does this comment have to change? spawnUri makes sense.

Fixed - bad search and replace.

> 
> We should change the callback API to include a boolean (isSpawnUri).

Bug filed.

> 
> This scheme of doing a string compare of the URIs won't work if somebody
issues
> a SpawnURI of the same URI because they want to load and execute a newer
version
> of the app in a new Isolate.

Good point.

[vsm, 2013-10-09 16:24:43]

Committed patchset #2 manually as r1423 (presubmit successful).

[ricow1, 2013-10-11 11:08:37]

https://codereview.chromium.org/26397003/diff/5001/Source/bindings/dart/DartC...
File Source/bindings/dart/DartController.cpp (right):

https://codereview.chromium.org/26397003/diff/5001/Source/bindings/dart/DartC...
Source/bindings/dart/DartController.cpp:384:
DartUtilities::reportProblem(context, "spawnFunction is not supported from a
dom-enabled isolate.  Please use spawnUri instead.");
Why don't we throw an exception here? This is messing up testing scripts since
the actual script will keep running, just sending more and more of these in many
cases - and with no way for the unittest framework to actually report something
sane to the user (i.e., we don't ever see this in the dart code.)