Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Issue 2639693003: MediaRecorder: add timecode validation in content_browsertests (Closed)

Created:
3 years, 11 months ago by mcasas
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: add timecode validation to content_browsertests Timecode was added recently (see bug) to the Spec and Chrome, this CL adds some validation of the produced timecodes, which boils down to they need to be monotonically increasing [1]. BUG=676211 [1] https://w3c.github.io/mediacapture-record/MediaRecorder.html#dom-blobevent-timecode Review-Url: https://codereview.chromium.org/2639693003 Cr-Commit-Position: refs/heads/master@{#444216} Committed: https://chromium.googlesource.com/chromium/src/+/8525c81d710cd9a5f92c343825094345e333afd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M content/test/data/media/mediarecorder_test.html View 9 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mcasas
reillyg@ PTAL (small test-only CL).
3 years, 11 months ago (2017-01-17 23:33:13 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-17 23:51:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639693003/1
3 years, 11 months ago (2017-01-18 00:28:05 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 01:09:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8525c81d710cd9a5f92c34382509...

Powered by Google App Engine
This is Rietveld 408576698