Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2639683002: Convert audiocontext-listener test to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audiocontext-listener test to testharness Manually convert test to use testharness and new Audit. Removed the expected result file too. BUG=678701 TEST=audiocontext-listener-should-not-crash.html Review-Url: https://codereview.chromium.org/2639683002 Cr-Commit-Position: refs/heads/master@{#445437} Committed: https://chromium.googlesource.com/chromium/src/+/b257ac3cf4858f2fb77fab58737dcf6bc3d3ca5a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html View 1 1 chunk +25 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-17 19:36:46 UTC) #2
hongchan
https://codereview.chromium.org/2639683002/diff/1/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html File third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html (right): https://codereview.chromium.org/2639683002/diff/1/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html#newcode1 third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html:1: <script src="../../resources/testharness.js"></script> Since we doing the manual work, I ...
3 years, 11 months ago (2017-01-19 12:42:45 UTC) #3
Raymond Toy
https://codereview.chromium.org/2639683002/diff/1/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html File third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html (right): https://codereview.chromium.org/2639683002/diff/1/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html#newcode1 third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html:1: <script src="../../resources/testharness.js"></script> On 2017/01/19 12:42:45, hongchan wrote: > Since ...
3 years, 11 months ago (2017-01-23 17:37:37 UTC) #4
hongchan
lgtm
3 years, 11 months ago (2017-01-23 17:39:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639683002/20001
3 years, 11 months ago (2017-01-23 17:46:08 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:45:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b257ac3cf4858f2fb77fab58737d...

Powered by Google App Engine
This is Rietveld 408576698