Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2639643002: Move audiocontext-getoutputtimestamp test to AudioContext (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move audiocontext-getoutputtimestamp test to AudioContext Move the test to the AudioContext directory where all tests for the AudioContext are located. BUG=681898 TEST= Review-Url: https://codereview.chromium.org/2639643002 Cr-Commit-Position: refs/heads/master@{#445541} Committed: https://chromium.googlesource.com/chromium/src/+/aaa433c5e54642be09cbdec198fd44f880e80c7b

Patch Set 1 #

Patch Set 2 : Convert to new Audit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-getoutputtimestamp.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/audiocontext-getoutputtimestamp.html View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-17 18:20:28 UTC) #2
hongchan
lgtm, but can we consider to change this to the new Audit? This test is ...
3 years, 11 months ago (2017-01-18 18:26:33 UTC) #3
Raymond Toy
On 2017/01/18 18:26:33, hongchan (OOO 1.17-1.19) wrote: > lgtm, but can we consider to change ...
3 years, 11 months ago (2017-01-18 18:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639643002/20001
3 years, 11 months ago (2017-01-23 20:47:50 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 23:23:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aaa433c5e54642be09cbdec198fd...

Powered by Google App Engine
This is Rietveld 408576698