Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2639593002: Measure impact of [SecureContext] on WebCrypto. (Closed)

Created:
3 years, 11 months ago by Mike West
Modified:
3 years, 10 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure impact of [SecureContext] on WebCrypto. https://github.com/w3ctag/design-principles/issues/32 reminded me that we still apply a weak version of secure context checks for WebCrypto. Let's see about changing that, shall we? R=jochen@chromium.org BUG=641526 Review-Url: https://codereview.chromium.org/2639593002 Cr-Commit-Position: refs/heads/master@{#451746} Committed: https://chromium.googlesource.com/chromium/src/+/ad615573268058885e7e43a15196e5936dc6237f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Mike West
WDYT, Jochen? rsleevi@: FYI.
3 years, 11 months ago (2017-01-17 14:37:49 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-23 07:31:32 UTC) #7
Ryan Sleevi
Updated the CL to refer to https://bugs.chromium.org/p/chromium/issues/detail?id=641526
3 years, 11 months ago (2017-01-23 21:01:42 UTC) #9
Ryan Sleevi
Oh and LGTM but you didn't need that :)
3 years, 11 months ago (2017-01-23 23:06:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639593002/20001
3 years, 10 months ago (2017-02-21 10:54:04 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 13:05:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad615573268058885e7e43a15196...

Powered by Google App Engine
This is Rietveld 408576698