mash: Do not use InProcessContextFactory in tests.

mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display compositor (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG=674001
Review-Url: https://codereview.chromium.org/2639513002
Cr-Commit-Position: refs/heads/master@{#444900}
Committed: https://chromium.googlesource.com/chromium/src/+/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27

[sadrul, 2017-01-17 05:55:50]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 05:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 06:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 06:45:25]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-19 04:24:47]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-01-19 04:45:20]

Sweet! I'm surprised all tests still pass! I vaguely recall trying this and not
passing? Oh well, some tests might've changed! This is awesome! LGTM

[sadrul, 2017-01-19 07:07:58]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2017-01-19 07:07:59]

+sky@ for owners

[Fady Samuel, 2017-01-19 14:08:22]

not: talks to display compositor not display manager in description.

[sky, 2017-01-19 16:37:40]

On 2017/01/19 14:08:22, Fady Samuel wrote:
> not: talks to display compositor not display manager in description.

How about updating the description then?

[sky, 2017-01-19 16:38:12]

LGTM

https://codereview.chromium.org/2639513002/diff/1/mash/test/mash_test_suite.h
File mash/test/mash_test_suite.h (right):

https://codereview.chromium.org/2639513002/diff/1/mash/test/mash_test_suite.h...
mash/test/mash_test_suite.h:21: class DummyContextFactory;
TestContextFactory?

[sadrul, 2017-01-19 18:58:25]

Description was changed from

==========
mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display manager (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG=674001
==========

to

==========
mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display compositor (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG=674001
==========

[sadrul, 2017-01-19 19:00:22]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-01-19 19:00:59]

Corrected the CL description too (s/display manager/display compositor/).

https://codereview.chromium.org/2639513002/diff/1/mash/test/mash_test_suite.h
File mash/test/mash_test_suite.h (right):

https://codereview.chromium.org/2639513002/diff/1/mash/test/mash_test_suite.h...
mash/test/mash_test_suite.h:21: class DummyContextFactory;
On 2017/01/19 16:38:12, sky wrote:
> TestContextFactory?

Done.

[commit-bot: I haz the power, 2017-01-19 19:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-19 20:03:04]

sadrul@chromium.org changed reviewers:
+ danakj@chromium.org

[sadrul, 2017-01-19 20:03:05]

+danakj@ for cc DEPS

[danakj, 2017-01-19 20:20:20]

LGTM

[sadrul, 2017-01-19 20:21:41]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2017-01-19 20:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2639513002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-01-19 20:22:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:53:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484857301914830,
"parent_rev": "b06715722249119894485b423b3bdeda2c18d60b", "commit_rev":
"a2fd53c7b0a8b9f0c657e94257059879c8fe7a27"}

[commit-bot: I haz the power, 2017-01-20 00:54:16]

Description was changed from

==========
mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display compositor (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG=674001
==========

to

==========
mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display compositor (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG=674001

Review-Url: https://codereview.chromium.org/2639513002
Cr-Commit-Position: refs/heads/master@{#444900}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2fd53c7b0a8b9f0c657e9425705...
==========

[commit-bot: I haz the power, 2017-01-20 00:54:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a2fd53c7b0a8b9f0c657e9425705...