Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3008)

Unified Diff: chrome/browser/resources/md_bookmarks/item.js

Issue 2639453002: [MD Bookmarks] Add Select for Bookmarks. (Closed)
Patch Set: comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/item.js
diff --git a/chrome/browser/resources/md_bookmarks/item.js b/chrome/browser/resources/md_bookmarks/item.js
index 13e698245beb96e9f96eee2344a157b7aadb109e..da41332a053d58f1905a76bfc19f1d2d03672c14 100644
--- a/chrome/browser/resources/md_bookmarks/item.js
+++ b/chrome/browser/resources/md_bookmarks/item.js
@@ -13,20 +13,31 @@ Polymer({
},
isFolder_: Boolean,
+
+ isSelected: {
+ type: Boolean,
+ reflectToAttribute: true,
+ },
},
observers: [
'updateFavicon_(item.url)',
],
+ listeners: {
+ 'click': 'onSingleClick_',
+ 'dblclick': 'onDoubleClick_',
+ },
+
/**
* @param {Event} e
* @private
*/
onMenuButtonOpenTap_: function(e) {
+ e.stopPropagation();
this.fire('open-item-menu', {
target: e.target,
- item: this.item
+ item: this.item,
});
},
@@ -35,7 +46,37 @@ Polymer({
this.isFolder_ = !(this.item.url);
},
- /** @private */
+ /**
+ * @param {Event} e
+ * @private
+ */
+ onSingleClick_: function(e) {
calamity 2017/01/17 06:12:22 nit: Just onClick_
jiaxi 2017/01/20 04:51:08 Done.
+ if (e.shiftKey)
+ this.fire('shift-select-multiple-items', {
+ item: this.item,
+ });
+ else if (e.ctrlKey)
+ this.fire('ctrl-select-multiple-items', {
+ item: this.item,
+ });
+ else
+ this.fire('select-single-item', {
+ item: this.item,
+ });
calamity 2017/01/17 06:12:22 Braces go around all multiline clauses. But in an
tsergeant 2017/01/17 06:16:53 Yeah, just fire IDs unless there's a good reason n
jiaxi 2017/01/20 04:51:08 Done.
+ },
+
+ /**
+ * @param {Event} e
+ * @private
+ */
+ onDoubleClick_: function(e) {
calamity 2017/01/17 06:12:22 onDblClick_
jiaxi 2017/01/20 04:51:08 Done.
+ /* TODO(jiaxi): Add double click later. */
+ },
+
+ /**
+ * @param {Event} e
+ * @private
+ */
updateFavicon_: function(url) {
this.$.icon.style.backgroundImage = cr.icon.getFavicon(url);
},

Powered by Google App Engine
This is Rietveld 408576698