Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2639453002: [MD Bookmarks] Add Select for Bookmarks. (Closed)

Created:
3 years, 11 months ago by jiaxi
Modified:
3 years, 10 months ago
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Add Select for Bookmarks. This CL enables single click to select items in the list. - Shift select. - Ctrl select. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2639453002 Cr-Commit-Position: refs/heads/master@{#448209} Committed: https://chromium.googlesource.com/chromium/src/+/feacdc993b7e6657fb5daa957de6e50a0fc6970b

Patch Set 1 #

Total comments: 9

Patch Set 2 : some fix #

Total comments: 1

Patch Set 3 : comment #

Total comments: 34

Patch Set 4 : selection after deletion #

Total comments: 19

Patch Set 5 : clean up #

Total comments: 20

Patch Set 6 : some more clean up #

Total comments: 22

Patch Set 7 : merge #

Patch Set 8 : restructure #

Total comments: 17

Patch Set 9 : clean up #

Total comments: 20

Patch Set 10 : fix closure #

Total comments: 2

Patch Set 11 : add shift+ctrl behaviours #

Total comments: 2

Patch Set 12 : add removeChild #

Patch Set 13 : add removeChild #

Total comments: 4

Patch Set 14 : minor fix #

Total comments: 7

Patch Set 15 : fixed some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -65 lines) Patch
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 2 3 4 5 6 7 8 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.html View 1 2 3 7 8 9 10 11 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 2 3 4 5 6 7 8 9 10 2 chunks +36 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/store.js View 1 2 3 4 5 6 7 8 9 10 11 12 11 chunks +162 lines, -19 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/item_test.js View 1 2 3 4 5 6 7 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/store_test.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 10 chunks +215 lines, -31 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/test_util.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +37 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 45 (13 generated)
jiaxi
https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js#newcode275 chrome/browser/resources/md_bookmarks/store.js:275: this.idToNodeMap_[this.selectedId].path + '.isSelectedFolder', false); ?
3 years, 11 months ago (2017-01-16 23:48:40 UTC) #3
jiaxi
https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js#newcode275 chrome/browser/resources/md_bookmarks/store.js:275: this.idToNodeMap_[this.selectedId].path + '.isSelectedFolder', false); On 2017/01/16 23:48:39, jiaxi wrote: ...
3 years, 11 months ago (2017-01-16 23:49:22 UTC) #4
angelayang
nice work! https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js#newcode56 chrome/browser/resources/md_bookmarks/store.js:56: 'folder-open-changed': this.onFolderOpenChanged_.bind(this), Nice, since you've got yours ...
3 years, 11 months ago (2017-01-17 00:46:51 UTC) #5
jiaxi
https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/1/chrome/browser/resources/md_bookmarks/store.js#newcode56 chrome/browser/resources/md_bookmarks/store.js:56: 'folder-open-changed': this.onFolderOpenChanged_.bind(this), On 2017/01/17 00:46:51, angelayang wrote: > Nice, ...
3 years, 11 months ago (2017-01-17 01:53:33 UTC) #6
angelayang
lgtm https://codereview.chromium.org/2639453002/diff/20001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/20001/chrome/browser/resources/md_bookmarks/store.js#newcode305 chrome/browser/resources/md_bookmarks/store.js:305: * Selected multiple items based on |prevSelectedItemIndex_| and ...
3 years, 11 months ago (2017-01-17 01:57:32 UTC) #7
jiaxi
3 years, 11 months ago (2017-01-17 02:52:09 UTC) #9
calamity
Cool, here's a few comments. https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.html File chrome/browser/resources/md_bookmarks/item.html (right): https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.html#newcode21 chrome/browser/resources/md_bookmarks/item.html:21: background-color: rgb(216, 223, 240); ...
3 years, 11 months ago (2017-01-17 06:12:23 UTC) #10
tsergeant
https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.js File chrome/browser/resources/md_bookmarks/item.js (right): https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.js#newcode65 chrome/browser/resources/md_bookmarks/item.js:65: }); On 2017/01/17 06:12:22, calamity wrote: > Braces go ...
3 years, 11 months ago (2017-01-17 06:16:53 UTC) #11
calamity
https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/store.js#newcode138 chrome/browser/resources/md_bookmarks/store.js:138: } Can we just set isSelected on the nodes ...
3 years, 11 months ago (2017-01-18 03:25:37 UTC) #12
jiaxi
Hi, massive patch https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.html File chrome/browser/resources/md_bookmarks/item.html (right): https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/item.html#newcode21 chrome/browser/resources/md_bookmarks/item.html:21: background-color: rgb(216, 223, 240); On 2017/01/17 ...
3 years, 11 months ago (2017-01-20 04:51:09 UTC) #15
calamity
https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/40001/chrome/browser/resources/md_bookmarks/store.js#newcode128 chrome/browser/resources/md_bookmarks/store.js:128: this.prevSelectedItemIndex_ = undefined; On 2017/01/20 04:51:09, jiaxi wrote: > ...
3 years, 11 months ago (2017-01-23 00:44:27 UTC) #16
jiaxi
https://codereview.chromium.org/2639453002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js File chrome/browser/resources/md_bookmarks/folder_node.js (right): https://codereview.chromium.org/2639453002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js#newcode59 chrome/browser/resources/md_bookmarks/folder_node.js:59: On 2017/01/23 00:44:27, calamity wrote: > On 2017/01/20 04:51:09, ...
3 years, 11 months ago (2017-01-23 06:14:46 UTC) #18
calamity
https://codereview.chromium.org/2639453002/diff/140001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/140001/chrome/browser/resources/md_bookmarks/store.js#newcode41 chrome/browser/resources/md_bookmarks/store.js:41: prevSelectedItemIndex_: Number, Hmm. I got confused by this thinking ...
3 years, 11 months ago (2017-01-24 06:39:17 UTC) #19
jiaxi
https://codereview.chromium.org/2639453002/diff/140001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/140001/chrome/browser/resources/md_bookmarks/store.js#newcode41 chrome/browser/resources/md_bookmarks/store.js:41: prevSelectedItemIndex_: Number, On 2017/01/24 06:39:17, calamity wrote: > Hmm. ...
3 years, 11 months ago (2017-01-25 03:26:11 UTC) #21
tsergeant
https://codereview.chromium.org/2639453002/diff/180001/chrome/browser/resources/md_bookmarks/folder_node.html File chrome/browser/resources/md_bookmarks/folder_node.html (right): https://codereview.chromium.org/2639453002/diff/180001/chrome/browser/resources/md_bookmarks/folder_node.html#newcode77 chrome/browser/resources/md_bookmarks/folder_node.html:77: <template is="dom-repeat" items="[[getFolders_(item.children)]]" dom-repeat has a built-in feature for ...
3 years, 11 months ago (2017-01-25 06:02:14 UTC) #22
jiaxi
https://codereview.chromium.org/2639453002/diff/180001/chrome/browser/resources/md_bookmarks/folder_node.html File chrome/browser/resources/md_bookmarks/folder_node.html (right): https://codereview.chromium.org/2639453002/diff/180001/chrome/browser/resources/md_bookmarks/folder_node.html#newcode77 chrome/browser/resources/md_bookmarks/folder_node.html:77: <template is="dom-repeat" items="[[getFolders_(item.children)]]" On 2017/01/25 06:02:13, tsergeant wrote: > ...
3 years, 10 months ago (2017-01-30 03:28:59 UTC) #24
tsergeant
Thanks for the patience~! https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/folder_node.html File chrome/browser/resources/md_bookmarks/folder_node.html (right): https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/folder_node.html#newcode78 chrome/browser/resources/md_bookmarks/folder_node.html:78: filter="isFolder_" observe="isSelectedFolder" as="child"> I think ...
3 years, 10 months ago (2017-01-30 06:39:47 UTC) #25
jiaxi
https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/folder_node.html File chrome/browser/resources/md_bookmarks/folder_node.html (right): https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/folder_node.html#newcode78 chrome/browser/resources/md_bookmarks/folder_node.html:78: filter="isFolder_" observe="isSelectedFolder" as="child"> On 2017/01/30 06:39:47, tsergeant wrote: > ...
3 years, 10 months ago (2017-01-31 00:37:43 UTC) #26
tsergeant
https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/store.js#newcode45 chrome/browser/resources/md_bookmarks/store.js:45: /** @type{Object<string, !boolean>} */ On 2017/01/31 00:37:42, jiaxi wrote: ...
3 years, 10 months ago (2017-01-31 01:55:35 UTC) #27
jiaxi
https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): https://codereview.chromium.org/2639453002/diff/240001/chrome/browser/resources/md_bookmarks/store.js#newcode45 chrome/browser/resources/md_bookmarks/store.js:45: /** @type{Object<string, !boolean>} */ On 2017/01/31 01:55:35, tsergeant wrote: ...
3 years, 10 months ago (2017-01-31 03:45:03 UTC) #29
calamity
https://codereview.chromium.org/2639453002/diff/260001/chrome/browser/resources/md_bookmarks/item.js File chrome/browser/resources/md_bookmarks/item.js (right): https://codereview.chromium.org/2639453002/diff/260001/chrome/browser/resources/md_bookmarks/item.js#newcode64 chrome/browser/resources/md_bookmarks/item.js:64: } Can this just be range: e.shiftKey, add: e.ctrlKey, ...
3 years, 10 months ago (2017-01-31 05:05:15 UTC) #30
jiaxi
https://codereview.chromium.org/2639453002/diff/260001/chrome/browser/resources/md_bookmarks/item.js File chrome/browser/resources/md_bookmarks/item.js (right): https://codereview.chromium.org/2639453002/diff/260001/chrome/browser/resources/md_bookmarks/item.js#newcode64 chrome/browser/resources/md_bookmarks/item.js:64: } On 2017/01/31 05:05:15, calamity wrote: > Can this ...
3 years, 10 months ago (2017-02-01 03:19:25 UTC) #31
tsergeant
I can't patch this in locally -- can you please do a rebase? (I think ...
3 years, 10 months ago (2017-02-02 00:16:02 UTC) #32
jiaxi
Hi, I've done the rebase and hopefully this time it works https://codereview.chromium.org/2639453002/diff/260001/chrome/browser/resources/md_bookmarks/store.js File chrome/browser/resources/md_bookmarks/store.js (right): ...
3 years, 10 months ago (2017-02-02 04:11:55 UTC) #33
tsergeant
Looks good! Just a couple more minor things https://codereview.chromium.org/2639453002/diff/360001/chrome/test/data/webui/md_bookmarks/store_test.js File chrome/test/data/webui/md_bookmarks/store_test.js (right): https://codereview.chromium.org/2639453002/diff/360001/chrome/test/data/webui/md_bookmarks/store_test.js#newcode20 chrome/test/data/webui/md_bookmarks/store_test.js:20: function ...
3 years, 10 months ago (2017-02-02 04:35:21 UTC) #34
jiaxi
https://codereview.chromium.org/2639453002/diff/360001/chrome/test/data/webui/md_bookmarks/store_test.js File chrome/test/data/webui/md_bookmarks/store_test.js (right): https://codereview.chromium.org/2639453002/diff/360001/chrome/test/data/webui/md_bookmarks/store_test.js#newcode20 chrome/test/data/webui/md_bookmarks/store_test.js:20: function removeChild(tree, index) { On 2017/02/02 04:35:21, tsergeant wrote: ...
3 years, 10 months ago (2017-02-02 05:28:36 UTC) #35
tsergeant
lgtm!
3 years, 10 months ago (2017-02-02 05:39:06 UTC) #36
calamity
https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js File chrome/test/data/webui/md_bookmarks/store_test.js (right): https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js#newcode217 chrome/test/data/webui/md_bookmarks/store_test.js:217: removeChild(TEST_TREE, 3); Shouldn't this test be removing the same ...
3 years, 10 months ago (2017-02-03 03:34:59 UTC) #37
jiaxi
https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js File chrome/test/data/webui/md_bookmarks/store_test.js (right): https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js#newcode217 chrome/test/data/webui/md_bookmarks/store_test.js:217: removeChild(TEST_TREE, 3); On 2017/02/03 03:34:59, calamity wrote: > Shouldn't ...
3 years, 10 months ago (2017-02-06 02:01:01 UTC) #38
calamity
lgtm https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js File chrome/test/data/webui/md_bookmarks/store_test.js (right): https://codereview.chromium.org/2639453002/diff/380001/chrome/test/data/webui/md_bookmarks/store_test.js#newcode217 chrome/test/data/webui/md_bookmarks/store_test.js:217: removeChild(TEST_TREE, 3); On 2017/02/06 02:01:01, jiaxi wrote: > ...
3 years, 10 months ago (2017-02-06 03:19:49 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639453002/400001
3 years, 10 months ago (2017-02-06 04:36:35 UTC) #42
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 05:34:58 UTC) #45
Message was sent while issue was closed.
Committed patchset #15 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/feacdc993b7e6657fb5daa957de6...

Powered by Google App Engine
This is Rietveld 408576698