Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5700)

Unified Diff: chrome/browser/resources/md_bookmarks/folder_node.html

Issue 2639453002: [MD Bookmarks] Add Select for Bookmarks. (Closed)
Patch Set: restructure Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/folder_node.html
diff --git a/chrome/browser/resources/md_bookmarks/folder_node.html b/chrome/browser/resources/md_bookmarks/folder_node.html
index e52117af9a9858c95724ceeadb5634ff9a28684c..e1497a2e6c904892c53f63ea6f41d28416f6a009 100644
--- a/chrome/browser/resources/md_bookmarks/folder_node.html
+++ b/chrome/browser/resources/md_bookmarks/folder_node.html
@@ -43,8 +43,8 @@
overflow: hidden;
}
- :host([is-selected]) .menu-label,
- :host([is-selected]) #folder-label {
+ :host([is-selected-folder]) .menu-label,
+ :host([is-selected-folder]) #folder-label {
color: var(--folder-active-color);
}
@@ -65,7 +65,7 @@
<div id="container" class="v-centered">
<div id="folder-label" class="v-centered" on-tap="selectFolder_">
- <iron-icon icon="[[getFolderIcon_(isSelected)]]"></iron-icon>
+ <iron-icon icon="[[getFolderIcon_(isSelectedFolder)]]"></iron-icon>
<div class="menu-label">[[item.title]]</div>
</div>
<template is="dom-if" if="[[hasChildFolder_(item.children)]]">
@@ -74,11 +74,11 @@
</template>
</div>
<div id="descendants" hidden$="[[!item.isOpen]]">
- <template is="dom-repeat" items="[[item.children]]" as="child">
- <template is="dom-if" if="[[!child.url]]">
- <bookmarks-folder-node item="[[child]]"
- is-selected="[[child.isSelected]]"></bookmarks-folder-node>
- </template>
+ <template is="dom-repeat" items="[[item.children]]"
+ filter="isFolder_" observe="isSelectedFolder" as="child">
tsergeant 2017/01/30 06:39:47 I think you want observe="url", since the isFolder
jiaxi 2017/01/31 00:37:42 Done.
+ <bookmarks-folder-node item="[[child]]"
+ is-selected-folder="[[child.isSelectedFolder]]">
+ </bookmarks-folder-node>
</template>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698