Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4304)

Unified Diff: chrome/browser/resources/md_bookmarks/folder_node.js

Issue 2639453002: [MD Bookmarks] Add Select for Bookmarks. (Closed)
Patch Set: selection after deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/folder_node.js
diff --git a/chrome/browser/resources/md_bookmarks/folder_node.js b/chrome/browser/resources/md_bookmarks/folder_node.js
index d58b28c2246418c6019b3f6fa11fc1e3b907eca4..2212a6c680f050e9fd166d734630768150438247 100644
--- a/chrome/browser/resources/md_bookmarks/folder_node.js
+++ b/chrome/browser/resources/md_bookmarks/folder_node.js
@@ -9,7 +9,7 @@ Polymer({
/** @type {BookmarkTreeNode} */
item: Object,
- isSelected: {
+ isSelectedFolder: {
type: Boolean,
value: false,
reflectToAttribute: true,
@@ -21,7 +21,7 @@ Polymer({
* @return {string}
*/
getFolderIcon_: function() {
- return this.isSelected ? 'bookmarks:folder-open' : 'cr:folder';
+ return this.isSelectedFolder ? 'bookmarks:folder-open' : 'cr:folder';
},
/**
@@ -54,6 +54,9 @@ Polymer({
* @return {boolean}
*/
hasChildFolder_: function() {
+ if (!this.item.children)
+ return false;
+
jiaxi 2017/01/20 04:51:09 This helps when a folder has been removed but the
calamity 2017/01/23 00:44:27 Does this get recalculated properly? You may need
jiaxi 2017/01/23 06:14:46 Done.
for (var i = 0; i < this.item.children.length; i++) {
if (!this.item.children[i].url)
return true;

Powered by Google App Engine
This is Rietveld 408576698