Skip creating spdy_session_pool dump if pool is empty in MemoryDumpProvider

Skip creating spdy_session_pool dump if pool is empty in MemoryDumpProvider

This CL skips creating a MemoryAllocatorDump for spdy_session_pool if the
pool is empty.

R=ssid@chromium.org

BUG=677346, 669108
Review-Url: https://codereview.chromium.org/2639403005
Cr-Commit-Position: refs/heads/master@{#445203}
Committed: https://chromium.googlesource.com/chromium/src/+/8397c08b01935f854e527ba42c9563ba852f1981

[xunjieli, 2017-01-19 15:09:55]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 15:10:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:33:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ssid, 2017-01-20 20:23:06]

Thanks for fixing lgtm.

[xunjieli, 2017-01-20 21:07:09]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-01-20 21:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2639403005/#ps40001
(title: "minor fix")

[commit-bot: I haz the power, 2017-01-20 21:07:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2017-01-20 21:35:58]

https://codereview.chromium.org/2639403005/diff/40001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.cc (right):

https://codereview.chromium.org/2639403005/diff/40001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.cc:390: if (sessions_.empty())
Could do this at the start of the function.  But why do we want to record if
total is 0, but sessions_ is not empty?

[xunjieli, 2017-01-20 21:42:58]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-01-20 21:45:26]

https://codereview.chromium.org/2639403005/diff/40001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.cc (right):

https://codereview.chromium.org/2639403005/diff/40001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.cc:390: if (sessions_.empty())
On 2017/01/20 21:35:58, ssid wrote:
> Could do this at the start of the function.  But why do we want to record if
> total is 0, but sessions_ is not empty?

Done. Good point!

[xunjieli, 2017-01-20 21:59:38]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-01-20 21:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2639403005/#ps60001
(title: "early return")

[commit-bot: I haz the power, 2017-01-20 21:59:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:14:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484949578921950,
"parent_rev": "80033375453f9664cf604323cfe0adb08ee5d765", "commit_rev":
"8397c08b01935f854e527ba42c9563ba852f1981"}

[commit-bot: I haz the power, 2017-01-20 23:14:32]

Description was changed from

==========
Skip creating spdy_session_pool dump if pool is empty in MemoryDumpProvider

This CL skips creating a MemoryAllocatorDump for spdy_session_pool if the
pool is empty.

R=ssid@chromium.org

BUG=677346,669108
==========

to

==========
Skip creating spdy_session_pool dump if pool is empty in MemoryDumpProvider

This CL skips creating a MemoryAllocatorDump for spdy_session_pool if the
pool is empty.

R=ssid@chromium.org

BUG=677346,669108

Review-Url: https://codereview.chromium.org/2639403005
Cr-Commit-Position: refs/heads/master@{#445203}
Committed:
https://chromium.googlesource.com/chromium/src/+/8397c08b01935f854e527ba42c95...
==========

[commit-bot: I haz the power, 2017-01-20 23:14:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8397c08b01935f854e527ba42c95...