Fix QuicAllowedPolicyDynamicTest browser_tests failures

Fix QuicAllowedPolicyDynamicTest browser_tests failures

QuicAllowedPolicyDynamicTest browser_tests have been failing on some
builders. Specifically, the tests expect QUIC to be enabled after
browser startup, but it was not. This CL adds kEnableQuic command-line
flag to the browser tests to ensure that QUIC is enabled on startup.

Note: This probably worked without the flag on other machines due to
field trials.

Note 2: I have confirmed locally that this patch helps by
- reproducing the gn args of the failing buildbot
  -> getting the exact same failure
- applying this patch
- rerunning the tests
  -> they pass now.

BUG=682484
TEST=browser_tests --gtest_filter=*QuicAllowedPolicyDynamicTest*

Review-Url: https://codereview.chromium.org/2639403004
Cr-Commit-Position: refs/heads/master@{#444733}
Committed: https://chromium.googlesource.com/chromium/src/+/17231785eecb024061d82c7097a78d3169503aff

[pmarko, 2017-01-19 13:12:37]

Description was changed from

==========
Fix QuicAllowedPolicyDynamicTest browser_tests failures

QuicAllowedPolicyDynamicTest browser_tests have been failing on some
builders. Specifically, the tests expect QUIC to be enabled after
browser startup, but it was not. This CL adds kEnableQuic command-line
flag to the browser tests to ensure that QUIC is enabled on startup.

Note: Probably this worked without the flag on other machines due to
field trials.

BUG=682484
TEST=browser_tests --gtest_filter=*QuicAllowedPolicyDynamicTest*
==========

to

==========
Fix QuicAllowedPolicyDynamicTest browser_tests failures

QuicAllowedPolicyDynamicTest browser_tests have been failing on some
builders. Specifically, the tests expect QUIC to be enabled after
browser startup, but it was not. This CL adds kEnableQuic command-line
flag to the browser tests to ensure that QUIC is enabled on startup.

Note: This probably worked without the flag on other machines due to
field trials.

Note 2: I have confirmed locally that this patch helps by
- reproducing the gn args of the failing buildbot
  -> getting the exact same failure
- applying this patch
- rerunning the tests
  -> they pass now.

BUG=682484
TEST=browser_tests --gtest_filter=*QuicAllowedPolicyDynamicTest*
==========

[pmarko, 2017-01-19 13:36:47]

pmarko@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[pmarko, 2017-01-19 13:36:48]

Please review the changes.

I have confirmed locally that this fixes the problem described in the bug,
however as there is no trybot which suffered from the problem I can not
demonstrate it there.

[pmarko, 2017-01-19 13:43:45]

On 2017/01/19 13:36:48, pmarko wrote:
> Please review the changes.
> 
> I have confirmed locally that this fixes the problem described in the bug,
> however as there is no trybot which suffered from the problem I can not
> demonstrate it there.

By the way, the tests derived from QuicAllowedPolicyTestBase also set this
command line flag: https://goo.gl/mrRQa6

[pastarmovj, 2017-01-19 14:32:51]

lgtm

[pmarko, 2017-01-19 14:34:09]

The CQ bit was checked by pmarko@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:34:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:10:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484836449414420,
"parent_rev": "e7af0866205dc516bb5a6b2cd3e020f9e8112aa8", "commit_rev":
"17231785eecb024061d82c7097a78d3169503aff"}

[commit-bot: I haz the power, 2017-01-19 15:11:14]

Description was changed from

==========
Fix QuicAllowedPolicyDynamicTest browser_tests failures

QuicAllowedPolicyDynamicTest browser_tests have been failing on some
builders. Specifically, the tests expect QUIC to be enabled after
browser startup, but it was not. This CL adds kEnableQuic command-line
flag to the browser tests to ensure that QUIC is enabled on startup.

Note: This probably worked without the flag on other machines due to
field trials.

Note 2: I have confirmed locally that this patch helps by
- reproducing the gn args of the failing buildbot
  -> getting the exact same failure
- applying this patch
- rerunning the tests
  -> they pass now.

BUG=682484
TEST=browser_tests --gtest_filter=*QuicAllowedPolicyDynamicTest*
==========

to

==========
Fix QuicAllowedPolicyDynamicTest browser_tests failures

QuicAllowedPolicyDynamicTest browser_tests have been failing on some
builders. Specifically, the tests expect QUIC to be enabled after
browser startup, but it was not. This CL adds kEnableQuic command-line
flag to the browser tests to ensure that QUIC is enabled on startup.

Note: This probably worked without the flag on other machines due to
field trials.

Note 2: I have confirmed locally that this patch helps by
- reproducing the gn args of the failing buildbot
  -> getting the exact same failure
- applying this patch
- rerunning the tests
  -> they pass now.

BUG=682484
TEST=browser_tests --gtest_filter=*QuicAllowedPolicyDynamicTest*

Review-Url: https://codereview.chromium.org/2639403004
Cr-Commit-Position: refs/heads/master@{#444733}
Committed:
https://chromium.googlesource.com/chromium/src/+/17231785eecb024061d82c7097a7...
==========

[commit-bot: I haz the power, 2017-01-19 15:11:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17231785eecb024061d82c7097a7...