Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2639333003: [intl] Check for duplicate BCP 47 tags in a case-insensitive way (Closed)

Created:
3 years, 11 months ago by Dan Ehrenberg
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Check for duplicate BCP 47 tags in a case-insensitive way Intl constructors are specified to prohibit structurally invalid subtags. BCP 47 defines itself to be case-insensitive. Firefox does throw on case-insensitive duplicates, following the specifications. This patch makes V8 do the same. There is some small compatibility risk, but the case is fairly niche, so I hope it does not cause much breakage. BUG=v8:4215 Review-Url: https://codereview.chromium.org/2639333003 Cr-Commit-Position: refs/heads/master@{#42487} Committed: https://chromium.googlesource.com/v8/v8/+/5e60bfb29d38d431a2bf6699f8ce040a396673c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M src/js/i18n.js View 1 chunk +2 lines, -0 lines 0 comments Download
A test/test262/local-tests/test/intl402/6.2.2_b.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Ehrenberg
3 years, 11 months ago (2017-01-18 19:48:04 UTC) #4
jungshik at Google
On 2017/01/18 19:48:04, Dan Ehrenberg wrote: Lgtm
3 years, 11 months ago (2017-01-19 04:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639333003/1
3 years, 11 months ago (2017-01-19 04:25:07 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 04:27:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5e60bfb29d38d431a2bf6699f8ce040a396...

Powered by Google App Engine
This is Rietveld 408576698