Test fixes for M57 ffmpeg roll.

Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG=677211, 677214
Review-Url: https://codereview.chromium.org/2639333002
Cr-Commit-Position: refs/heads/master@{#444428}
Committed: https://chromium.googlesource.com/chromium/src/+/acc729512852c66d25b86ebf3533c1531d331983

[liberato (no reviews please), 2017-01-18 17:41:20]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 17:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-01-18 17:51:29]

Description was changed from

==========
Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG=677211,677214
==========

to

==========
Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG=677211,677214
==========

[liberato (no reviews please), 2017-01-18 17:51:30]

liberato@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-01-18 18:20:31]

lgtm

https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integra...
File media/test/pipeline_integration_test_base.cc (right):

https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integra...
media/test/pipeline_integration_test_base.cc:155: EXPECT_CALL(*this,
OnVideoOpacityChange(_)).WillRepeatedly(Return());
.Times(AnyNumber()) also works.

[commit-bot: I haz the power, 2017-01-18 18:47:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 18:47:31]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2017-01-18 18:49:21]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2017-01-18 18:49:29]

https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integra...
File media/test/pipeline_integration_test_base.cc (right):

https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integra...
media/test/pipeline_integration_test_base.cc:155: EXPECT_CALL(*this,
OnVideoOpacityChange(_)).WillRepeatedly(Return());
On 2017/01/18 18:20:31, DaleCurtis wrote:
> .Times(AnyNumber()) also works.

didn't know that, thanks!

[commit-bot: I haz the power, 2017-01-18 18:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 18:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484765361473080, "parent_rev":
"6698ed7caa74c72258b7a54001c1bd361a4722c0", "commit_rev":
"acc729512852c66d25b86ebf3533c1531d331983"}

[commit-bot: I haz the power, 2017-01-18 18:55:09]

Description was changed from

==========
Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG=677211,677214
==========

to

==========
Test fixes for M57 ffmpeg roll.

Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 .  Now OnOpacityChanged may
be called any number of times.  449958 does really switch opacity twice.

ffmpeg regression tests MP4_17 now fails (correctly) with
DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK

BUG=677211,677214

Review-Url: https://codereview.chromium.org/2639333002
Cr-Commit-Position: refs/heads/master@{#444428}
Committed:
https://chromium.googlesource.com/chromium/src/+/acc729512852c66d25b86ebf3533...
==========

[commit-bot: I haz the power, 2017-01-18 18:55:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/acc729512852c66d25b86ebf3533...