Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2639333002: Test fixes for M57 ffmpeg roll. (Closed)

Created:
3 years, 11 months ago by liberato (no reviews please)
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test fixes for M57 ffmpeg roll. Fixed Cr449958/FFmpegRegressionTest.BasicPlayback/0 . Now OnOpacityChanged may be called any number of times. 449958 does really switch opacity twice. ffmpeg regression tests MP4_17 now fails (correctly) with DEMUXER_ERROR_COULD_NOT_OPEN, rather than PIPELINE_OK BUG=677211, 677214 Review-Url: https://codereview.chromium.org/2639333002 Cr-Commit-Position: refs/heads/master@{#444428} Committed: https://chromium.googlesource.com/chromium/src/+/acc729512852c66d25b86ebf3533c1531d331983

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M media/ffmpeg/ffmpeg_regression_tests.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.cc View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 14 (9 generated)
liberato (no reviews please)
3 years, 11 months ago (2017-01-18 17:51:45 UTC) #5
DaleCurtis
lgtm https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integration_test_base.cc File media/test/pipeline_integration_test_base.cc (right): https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integration_test_base.cc#newcode155 media/test/pipeline_integration_test_base.cc:155: EXPECT_CALL(*this, OnVideoOpacityChange(_)).WillRepeatedly(Return()); .Times(AnyNumber()) also works.
3 years, 11 months ago (2017-01-18 18:20:31 UTC) #6
liberato (no reviews please)
https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integration_test_base.cc File media/test/pipeline_integration_test_base.cc (right): https://codereview.chromium.org/2639333002/diff/1/media/test/pipeline_integration_test_base.cc#newcode155 media/test/pipeline_integration_test_base.cc:155: EXPECT_CALL(*this, OnVideoOpacityChange(_)).WillRepeatedly(Return()); On 2017/01/18 18:20:31, DaleCurtis wrote: > .Times(AnyNumber()) ...
3 years, 11 months ago (2017-01-18 18:49:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639333002/1
3 years, 11 months ago (2017-01-18 18:50:00 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 18:55:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/acc729512852c66d25b86ebf3533...

Powered by Google App Engine
This is Rietveld 408576698