Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2639313002: Migrate desktop Linux to histogram_macros.h include. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, vmpstr+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, dcheng, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate desktop Linux to histogram_macros.h include. Updates ifdefs in histogram.h to prevent this from regressing for Linux desktop. The ifdef will be updated incrementally as each platform becomes fully migrated. BUG=416479 TBR=gbillock@chromium.org,tommi@chromium.org,stevenjb@chromium.org,rockot@chromium.org,sadrul@chromium.org Review-Url: https://codereview.chromium.org/2639313002 Cr-Commit-Position: refs/heads/master@{#444736} Committed: https://chromium.googlesource.com/chromium/src/+/12d9cdafee5f8ed2fa72868ec75c34eec0216000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M base/metrics/histogram.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/exported_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/object_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_status_manager_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_pairing_bluez.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-18 16:13:36 UTC) #8
Ilya Sherman
LGTM, thanks.
3 years, 11 months ago (2017-01-19 02:21:25 UTC) #11
Alexei Svitkine (slow)
TBR += gbillock@chromium.org,tommi@chromium.org,stevenjb@chromium.org,rockot@chromium.org,sadrul@chromium.org for downstream changes of base/metrics - just changing includes
3 years, 11 months ago (2017-01-19 15:13:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639313002/20001
3 years, 11 months ago (2017-01-19 15:14:10 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 15:18:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12d9cdafee5f8ed2fa72868ec75c...

Powered by Google App Engine
This is Rietveld 408576698