Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2639273002: Give WebTouchEvent and WebKeyboardEvent their own headers (Closed)

Created:
3 years, 11 months ago by dtapuska
Modified:
3 years, 11 months ago
CC:
chromium-reviews, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, kinuko+watch, sebsg+autofillwatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, Navid Zolghadr, blink-reviews, einbinder+watch-test-runner_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, rouslan+autofill_chromium.org, eae+blinkwatch, vabr+watchlistautofill_chromium.org, jochen+watch_chromium.org, dtapuska+blinkwatch_chromium.org, mlamouri+watch-test-runner_chromium.org, mathp+autofillwatch_chromium.org, dtapuska+chromiumwatch_chromium.org, blink-reviews-events_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give WebTouchEvent and WebKeyboardEvent their own headers No functional changes intended. Just moving code around to make clear structs be defined in their own header. BUG=625684 TBR=jochen@chromium.org, dcheng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2639273002 Cr-Commit-Position: refs/heads/master@{#445166} Committed: https://chromium.googlesource.com/chromium/src/+/a64845daa6b3951b2f6891c6bbf37cfff568dde9

Patch Set 1 #

Patch Set 2 : Fix build errors #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -128 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/event_sender.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/text_input_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_web.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/input/synthetic_pointer_action_params.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/input/touch_event_stream_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/touch_event_stream_validator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/web_touch_event_traits.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/input/web_touch_event_traits.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 chunk +0 lines, -113 lines 0 comments Download
A third_party/WebKit/public/platform/WebKeyboardEvent.h View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebTouchEvent.h View 1 chunk +57 lines, -0 lines 0 comments Download
M ui/events/blink/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/web_input_event.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/web_input_event_builders_win.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event_traits.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/web_input_event_traits_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (20 generated)
dtapuska
rbyers@ no functional changes intended.
3 years, 11 months ago (2017-01-19 19:55:01 UTC) #15
Rick Byers
LGTM
3 years, 11 months ago (2017-01-20 19:08:21 UTC) #17
dtapuska
dcheng@chromium.org: Please review changes in paramtraits_unittest* jochen@chromium.org: Please review changes in content/*, component/*
3 years, 11 months ago (2017-01-20 19:18:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639273002/40001
3 years, 11 months ago (2017-01-20 19:20:07 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 21:21:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a64845daa6b3951b2f6891c6bbf3...

Powered by Google App Engine
This is Rietveld 408576698