android: Check GSA's broadcast permission.

android: Check GSA's broadcast permission.

GSA can either notify Chrome of account changes through a service, or
through a broadcast. The broadcast requires a permission to be granted
to Chrome in order to receive it. This commit adds a check in Chrome
that the permission is granted before switching to it.

BUG=614388
Review-Url: https://codereview.chromium.org/2639263002
Cr-Commit-Position: refs/heads/master@{#445075}
Committed: https://chromium.googlesource.com/chromium/src/+/b34883d3328151ed5f81aa7ec8607b401d39d088

[Benoit L, 2017-01-18 15:00:08]

lizeb@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Benoit L, 2017-01-19 17:29:13]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org
- tedchoc@chromium.org

[Benoit L, 2017-01-19 17:29:14]

-R: tedchoc
+R: yusufo

Now that I got the power, no need to nag Ted with this review.

Yusuf, PTAL, thanks :-)

[Ted C, 2017-01-19 17:55:05]

tedchoc@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2017-01-19 17:55:05]

now, that I'm not the reviewer :-P

https://codereview.chromium.org/2639263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java
(right):

https://codereview.chromium.org/2639263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java:125:
try {
out of curiosity, could we use this instead:

if (ApiCompatibilityUtils.checkPermission(
        ACCOUNT_UPDATE_BROADCAST_PERMISSION, Process.myPid(), Process.myUid())
        == PackageManager.PERMISSION_GRANTED) {
    return;
}

Wondering if this is different and why than querying packagemanager directly

[Benoit L, 2017-01-20 13:09:52]

Thanks!

https://codereview.chromium.org/2639263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java
(right):

https://codereview.chromium.org/2639263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java:125:
try {
On 2017/01/19 17:55:05, Ted C wrote:
> out of curiosity, could we use this instead:
> 
> if (ApiCompatibilityUtils.checkPermission(
>         ACCOUNT_UPDATE_BROADCAST_PERMISSION, Process.myPid(), Process.myUid())
>         == PackageManager.PERMISSION_GRANTED) {
>     return;
> }
> 
> Wondering if this is different and why than querying packagemanager directly

Thanks!

Shadok Motto: "Why do it the easy way when you can do it the hard way?"
(https://en.wikipedia.org/wiki/Les_Shadoks)

[Benoit L, 2017-01-20 13:09:57]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:10:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 13:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 13:47:25]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-20 16:34:57]

lgtm

[Benoit L, 2017-01-20 16:38:01]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2017-01-20 16:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 16:42:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484930281944020,
"parent_rev": "1410a29d40e4809519e02ffabf3edf20dee1511c", "commit_rev":
"b34883d3328151ed5f81aa7ec8607b401d39d088"}

[commit-bot: I haz the power, 2017-01-20 16:42:51]

Description was changed from

==========
android: Check GSA's broadcast permission.

GSA can either notify Chrome of account changes through a service, or
through a broadcast. The broadcast requires a permission to be granted
to Chrome in order to receive it. This commit adds a check in Chrome
that the permission is granted before switching to it.

BUG=614388
==========

to

==========
android: Check GSA's broadcast permission.

GSA can either notify Chrome of account changes through a service, or
through a broadcast. The broadcast requires a permission to be granted
to Chrome in order to receive it. This commit adds a check in Chrome
that the permission is granted before switching to it.

BUG=614388

Review-Url: https://codereview.chromium.org/2639263002
Cr-Commit-Position: refs/heads/master@{#445075}
Committed:
https://chromium.googlesource.com/chromium/src/+/b34883d3328151ed5f81aa7ec860...
==========

[commit-bot: I haz the power, 2017-01-20 16:42:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b34883d3328151ed5f81aa7ec860...