Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2639203003: Add certificate error handling to devtools. (Closed)
Patch Set: Fixed test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 01a810115cad34d45f09f089116e46209c11b174..ae7b8b1c8b537c3fa47b91c1ba81d958f8c93b3e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1467,6 +1467,17 @@ void WebContentsImpl::DidChangeVisibleSecurityState() {
}
}
+bool WebContentsImpl::NotifyCertificateError(
+ base::Callback<void(content::CertificateRequestResultType)> callback) {
+ bool handled = false;
+ for (auto& observer : observers_)
Sami 2017/02/08 14:58:43 nit: I'd add braces around the multi-line for loop
irisu 2017/02/14 05:46:14 Done.
+ if (observer.NotifyCertificateError(callback)) {
+ handled = true;
+ break;
+ }
+ return handled;
+}
+
void WebContentsImpl::Stop() {
for (FrameTreeNode* node : frame_tree_.Nodes())
node->StopLoading();

Powered by Google App Engine
This is Rietveld 408576698