Add certificate error handling to devtools.

content/browser/ssl/ssl_manager.cc

Index: content/browser/ssl/ssl_manager.cc
diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index df2e7575b49da85f0455e6e880cc5e0f01d02318..abfca595af8cda7dec8dbc229fa75a8d5ccdf71a 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -356,11 +356,16 @@ void SSLManager::OnCertErrorInternal(std::unique_ptr<SSLErrorHandler> handler,
   const net::SSLInfo& ssl_info = handler->ssl_info();
   const GURL& request_url = handler->request_url();
   ResourceType resource_type = handler->resource_type();
-  GetContentClient()->browser()->AllowCertificateError(
-      web_contents, cert_error, ssl_info, request_url, resource_type,
-      overridable, strict_enforcement, expired_previous_decision,
+
+  base::Callback<void(content::CertificateRequestResultType)> callback =
       base::Bind(&OnAllowCertificate, base::Owned(handler.release()),
-                 ssl_host_state_delegate_));
+                 ssl_host_state_delegate_);
+
+  if (!web_contents->NotifyCertificateError(callback)) {

[pfeldman, 2017/02/08 18:24:00]

Fetch devtools_agent_host_impl associated with the web_contents and plumb error
there.

[irisu, 2017/02/14 05:46:14]

I'm not exactly sure how to do this. I can fetch the devtools_agent_host, but
from there I'm not sure how to get to the security_handler. To my understanding,
the handlers are attached to the devtools_session but I'm not sure how to access
that. Mind giving me some pointers there, please? :)

[Eric Seckler, 2017/02/14 18:42:24]

We could add a static method to RenderFrameDevToolsAgentHost, similar to
RenderFrameDevToolsAgentHost::UserAgentOverride. See its implementation here:
https://cs.chromium.org/chromium/src/content/browser/devtools/render_frame_de...

Pavel can advise whether that's the way to go :)

[pfeldman, 2017/02/14 19:00:24]

Something like that would do, I would even put this static method on the
security_handler itself - that way you can emphasize that it covers non-frame
target types as well.

[irisu, 2017/02/16 00:24:30]

I've added this in RenderFrameDevToolsAgentHost for now, as to my understanding,
I can't use agent_host->session() outside of that since it is protected. Is
there a different way I'm missing?

+    GetContentClient()->browser()->AllowCertificateError(
+        web_contents, cert_error, ssl_info, request_url, resource_type,
+        overridable, strict_enforcement, expired_previous_decision, callback);
+  }
 }
 
 void SSLManager::UpdateEntry(NavigationEntryImpl* entry,