Add certificate error handling to devtools.

content/browser/ssl/ssl_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/ssl/ssl_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 338 matching lines @@
   bool overridable = (options_mask & OVERRIDABLE) != 0;
   bool strict_enforcement = (options_mask & STRICT_ENFORCEMENT) != 0;
   bool expired_previous_decision =
       (options_mask & EXPIRED_PREVIOUS_DECISION) != 0;
 
   WebContents* web_contents = handler->web_contents();
   int cert_error = handler->cert_error();
   const net::SSLInfo& ssl_info = handler->ssl_info();
   const GURL& request_url = handler->request_url();
   ResourceType resource_type = handler->resource_type();
-  GetContentClient()->browser()->AllowCertificateError(
-      web_contents, cert_error, ssl_info, request_url, resource_type,
-      overridable, strict_enforcement, expired_previous_decision,
+
+  base::Callback<void(content::CertificateRequestResultType)> callback =
       base::Bind(&OnAllowCertificate, base::Owned(handler.release()),
-                 ssl_host_state_delegate_));
+                 ssl_host_state_delegate_);
+
+  if (!web_contents->NotifyCertificateError(callback)) {

[pfeldman, 2017/02/08 18:24:00]

Fetch devtools_agent_host_impl associated with the web_contents and plumb error
there.

[irisu, 2017/02/14 05:46:14]

I'm not exactly sure how to do this. I can fetch the devtools_agent_host, but
from there I'm not sure how to get to the security_handler. To my understanding,
the handlers are attached to the devtools_session but I'm not sure how to access
that. Mind giving me some pointers there, please? :)

[Eric Seckler, 2017/02/14 18:42:24]

We could add a static method to RenderFrameDevToolsAgentHost, similar to
RenderFrameDevToolsAgentHost::UserAgentOverride. See its implementation here:
https://cs.chromium.org/chromium/src/content/browser/devtools/render_frame_de...

Pavel can advise whether that's the way to go :)

[pfeldman, 2017/02/14 19:00:24]

Something like that would do, I would even put this static method on the
security_handler itself - that way you can emphasize that it covers non-frame
target types as well.

[irisu, 2017/02/16 00:24:30]

I've added this in RenderFrameDevToolsAgentHost for now, as to my understanding,
I can't use agent_host->session() outside of that since it is protected. Is
there a different way I'm missing?

+    GetContentClient()->browser()->AllowCertificateError(
+        web_contents, cert_error, ssl_info, request_url, resource_type,
+        overridable, strict_enforcement, expired_previous_decision, callback);
+  }
 }
 
 void SSLManager::UpdateEntry(NavigationEntryImpl* entry,
                              int add_content_status_flags,
                              int remove_content_status_flags) {
   // We don't always have a navigation entry to update, for example in the
   // case of the Web Inspector.
   if (!entry)
     return;
 
@@ skipping 47 matching lines @@
   SSLManagerSet* managers =
       static_cast<SSLManagerSet*>(context->GetUserData(kSSLManagerKeyName));
 
   for (std::set<SSLManager*>::iterator i = managers->get().begin();
        i != managers->get().end(); ++i) {
     (*i)->UpdateEntry((*i)->controller()->GetLastCommittedEntry(), 0, 0);
   }
 }
 
 }  // namespace content