Add certificate error handling to devtools.

content/browser/devtools/protocol/security_handler.h

Index: content/browser/devtools/protocol/security_handler.h
diff --git a/content/browser/devtools/protocol/security_handler.h b/content/browser/devtools/protocol/security_handler.h
index 2d32c687a40374a5df7980595827ee2711f067d6..44df370ce32a7fbcc0cb8be7e9d011ef8783c06d 100644
--- a/content/browser/devtools/protocol/security_handler.h
+++ b/content/browser/devtools/protocol/security_handler.h
@@ -5,9 +5,12 @@
 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_SECURITY_HANDLER_H_
 
+#include <unordered_map>
+
 #include "base/macros.h"
 #include "content/browser/devtools/protocol/devtools_domain_handler.h"
 #include "content/browser/devtools/protocol/security.h"
+#include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/web_contents_observer.h"
 
 namespace content {
@@ -29,16 +32,22 @@ class SecurityHandler : public DevToolsDomainHandler,
   Response Enable() override;
   Response Disable() override;
   Response ShowCertificateViewer() override;
+  Response HandleCertificateError(int, const String&) override;

[Eric Seckler, 2017/01/19 11:42:28]

nit: int event_id, const String& action

(I think the style guide regarding parameter names in func def is to only omit
them if they're obvious.)

[irisu, 2017/02/07 23:30:19]

Done.

 
  private:
   void AttachToRenderFrameHost();
 
+  using CertErrorHandlerMap = std::unordered_map<int, CertErrorHandler>;
+
   // WebContentsObserver overrides
   void DidChangeVisibleSecurityState() override;
+  bool NotifyCertificateError(CertErrorHandler) override;
 
   std::unique_ptr<Security::Frontend> frontend_;
   bool enabled_;
   RenderFrameHostImpl* host_;
+  int cert_error_id_;

[Eric Seckler, 2017/01/19 11:42:28]

nit: next_cert_error_id_ 

We should probably also init this in constructor to some sensible value (0?).

[irisu, 2017/02/07 23:30:19]

Done.

+  CertErrorHandlerMap handlers_;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityHandler);
 };