Add certificate error handling to devtools.

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index d2d04bebfe84e4c04fa38465dad61c91a542fe16..4c885e9c580d212519af41f059c9ede376102687 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1274,6 +1274,19 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, ShowCertificateViewer) {
   EXPECT_EQ(transient_entry->GetSSL().certificate, last_shown_certificate());
 }
 
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, CertificateError) {
+  net::EmbeddedTestServer https_server(net::EmbeddedTestServer::TYPE_HTTPS);
+  https_server.SetSSLConfig(net::EmbeddedTestServer::CERT_EXPIRED);
+  ASSERT_TRUE(https_server.Start());
+  GURL test_url = https_server.GetURL("/devtools/navigation.html");
+
+  Attach();
+  SendCommand("Security.enable", nullptr, true);

[Eric Seckler, 2017/01/19 11:42:28]

I'm considering whether we should add an additional command that enables
certificate error handling separately (e.g.
"Security.enableCertificateErrorHandling").

That would allow clients to receive securityStateChanged notifications without
also having to handle certificateError events - and means that things don't
change for existing clients (which wouldn't know that they need to respond to
certificateError events with the handleCertificateError command).

WDYT? :)

[irisu, 2017/02/07 23:30:19]

Done.

+  shell()->LoadURL(test_url);
+
+  WaitForNotification("Security.certificateError", true);

[Eric Seckler, 2017/01/19 11:42:28]

Shall we also add tests for handleCertificateError and the different actions
that we can take?

[irisu, 2017/02/07 23:30:19]

As discussed - this has been a struggle.

+}
+
 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
   std::string temp;
   std::set<std::string> ids;