Add certificate error handling to devtools.

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 1256 matching lines @@
       web_contents->GetController().GetTransientEntry();
   ASSERT_TRUE(transient_entry);
   transient_entry->GetSSL().certificate = expired_cert();
   ASSERT_TRUE(transient_entry->GetSSL().certificate);
 
   std::unique_ptr<base::DictionaryValue> params2(new base::DictionaryValue());
   SendCommand("Security.showCertificateViewer", std::move(params2), true);
   EXPECT_EQ(transient_entry->GetSSL().certificate, last_shown_certificate());
 }
 
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, CertificateError) {
+  net::EmbeddedTestServer https_server(net::EmbeddedTestServer::TYPE_HTTPS);
+  https_server.SetSSLConfig(net::EmbeddedTestServer::CERT_EXPIRED);
+  ASSERT_TRUE(https_server.Start());
+  GURL test_url = https_server.GetURL("/devtools/navigation.html");
+
+  Attach();
+  SendCommand("Security.enable", nullptr, true);

[Eric Seckler, 2017/01/19 11:42:28]

I'm considering whether we should add an additional command that enables
certificate error handling separately (e.g.
"Security.enableCertificateErrorHandling").

That would allow clients to receive securityStateChanged notifications without
also having to handle certificateError events - and means that things don't
change for existing clients (which wouldn't know that they need to respond to
certificateError events with the handleCertificateError command).

WDYT? :)

[irisu, 2017/02/07 23:30:19]

Done.

+  shell()->LoadURL(test_url);
+
+  WaitForNotification("Security.certificateError", true);

[Eric Seckler, 2017/01/19 11:42:28]

Shall we also add tests for handleCertificateError and the different actions
that we can take?

[irisu, 2017/02/07 23:30:19]

As discussed - this has been a struggle.

+}
+
 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
   std::string temp;
   std::set<std::string> ids;
   std::unique_ptr<base::DictionaryValue> command_params;
   std::unique_ptr<base::DictionaryValue> params;
 
   ASSERT_TRUE(embedded_test_server()->Start());
   GURL first_url = embedded_test_server()->GetURL("/devtools/navigation.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), first_url, 1);
 
@@ skipping 220 matching lines @@
       EXPECT_EQ("polyglottal", value);
       found++;
     } else {
       FAIL();
     }
   }
   EXPECT_EQ(2u, found);
 }
 
 }  // namespace content