Add certificate error handling to devtools.

content/browser/devtools/render_frame_devtools_agent_host.cc

Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index fbd7c4a2b43609aa8a1f0ba6c99ddd98bcbad832..e43d6077e6c6576762d51ceee452bef21a680c5b 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -432,6 +432,17 @@ void RenderFrameDevToolsAgentHost::WebContentsCreated(
   }
 }
 
+bool RenderFrameDevToolsAgentHost::NotifyCertificateError(
+    RenderFrameDevToolsAgentHost* agent_host,
+    int cert_error,
+    const GURL& request_url,
+    base::Callback<void(content::CertificateRequestResultType)> callback) {

[pfeldman, 2017/02/16 01:35:34]

Otherwise this looks awkward: you call a static method and pass actual instance
of that class as a first argument. Also, it works for workers as well, so going
through this class is misleading.

[Eric Seckler, 2017/02/16 02:01:07]

I think Iris was wondering if we can make DevToolsAgentHostImpl::session() a
public accessor. It's protected at the moment, but also has a "TODO(dgozman):
remove this accessor", so it's not really clear to us what's up with that :)

[irisu, 2017/02/16 04:47:32]

Yes, that's what I'm confused about.

+  if (!agent_host || !agent_host->session())
+    return false;
+  return protocol::SecurityHandler::FromSession(agent_host->session())
+      ->NotifyCertificateError(cert_error, request_url, callback);
+}
+
 RenderFrameDevToolsAgentHost::RenderFrameDevToolsAgentHost(
     RenderFrameHostImpl* host)
     : DevToolsAgentHostImpl(base::GenerateGUID()),