Add certificate error handling to devtools.

content/browser/devtools/render_frame_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
 
 #include <tuple>
 #include <utility>
 
 #include "base/guid.h"
@@ skipping 414 matching lines @@
 
 // static
 void RenderFrameDevToolsAgentHost::WebContentsCreated(
     WebContents* web_contents) {
   if (ShouldForceCreation()) {
     // Force agent host.
     DevToolsAgentHost::GetOrCreateFor(web_contents);
   }
 }
 
+bool RenderFrameDevToolsAgentHost::NotifyCertificateError(
+    RenderFrameDevToolsAgentHost* agent_host,
+    int cert_error,
+    const GURL& request_url,
+    base::Callback<void(content::CertificateRequestResultType)> callback) {

[pfeldman, 2017/02/16 01:35:34]

Otherwise this looks awkward: you call a static method and pass actual instance
of that class as a first argument. Also, it works for workers as well, so going
through this class is misleading.

[Eric Seckler, 2017/02/16 02:01:07]

I think Iris was wondering if we can make DevToolsAgentHostImpl::session() a
public accessor. It's protected at the moment, but also has a "TODO(dgozman):
remove this accessor", so it's not really clear to us what's up with that :)

[irisu, 2017/02/16 04:47:32]

Yes, that's what I'm confused about.

+  if (!agent_host || !agent_host->session())
+    return false;
+  return protocol::SecurityHandler::FromSession(agent_host->session())
+      ->NotifyCertificateError(cert_error, request_url, callback);
+}
+
 RenderFrameDevToolsAgentHost::RenderFrameDevToolsAgentHost(
     RenderFrameHostImpl* host)
     : DevToolsAgentHostImpl(base::GenerateGUID()),
       frame_trace_recorder_(nullptr),
       handlers_frame_host_(nullptr),
       current_frame_crashed_(false),
       pending_handle_(nullptr),
       frame_tree_node_(host->frame_tree_node()) {
   SetPending(host);
   CommitPending();
@@ skipping 707 matching lines @@
     RenderFrameHost* host) {
   return (current_ && current_->host() == host) ||
       (pending_ && pending_->host() == host);
 }
 
 bool RenderFrameDevToolsAgentHost::IsChildFrame() {
   return current_ && current_->host()->GetParent();
 }
 
 }  // namespace content