Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2639153002: Make extensions DSE persistent in browser prefs (Reland) (Closed)
Patch Set: Minor fix after review, round 7 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_manager_unittest.cc
diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc
index 3d0bea1a95a33445ca0ee8767586d30bdc13687b..d624e05f8393556cfaf0f0aff17a11bbbf9fdecb 100644
--- a/components/search_engines/default_search_manager_unittest.cc
+++ b/components/search_engines/default_search_manager_unittest.cc
@@ -235,8 +235,7 @@ TEST_F(DefaultSearchManagerTest, DefaultSearchSetByExtension) {
// Extension trumps prefs:
std::unique_ptr<TemplateURLData> extension_data_1 =
GenerateDummyTemplateURLData("ext1");
- manager.SetExtensionControlledDefaultSearchEngine(*extension_data_1);
-
+ SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_1);
ExpectSimilar(extension_data_1.get(),
manager.GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
@@ -256,15 +255,14 @@ TEST_F(DefaultSearchManagerTest, DefaultSearchSetByExtension) {
GenerateDummyTemplateURLData("ext2");
std::unique_ptr<TemplateURLData> extension_data_3 =
GenerateDummyTemplateURLData("ext3");
- manager.SetExtensionControlledDefaultSearchEngine(*extension_data_2);
- manager.SetExtensionControlledDefaultSearchEngine(*extension_data_3);
+ SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_2);
+ SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_3);
ExpectSimilar(extension_data_3.get(),
manager.GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
- manager.ClearExtensionControlledDefaultSearchEngine();
-
+ RemoveExtensionDefaultSearchFromPrefs(pref_service());
ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
}
« no previous file with comments | « components/search_engines/default_search_manager.cc ('k') | components/search_engines/search_engines_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698