Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2639153002: Make extensions DSE persistent in browser prefs (Reland) (Closed)
Patch Set: Minor fix after review, round 7 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_engines/default_search_manager.h" 5 #include "components/search_engines/default_search_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user"); 228 std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user");
229 manager.SetUserSelectedDefaultSearchEngine(*data); 229 manager.SetUserSelectedDefaultSearchEngine(*data);
230 230
231 DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK; 231 DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK;
232 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source)); 232 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
233 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 233 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
234 234
235 // Extension trumps prefs: 235 // Extension trumps prefs:
236 std::unique_ptr<TemplateURLData> extension_data_1 = 236 std::unique_ptr<TemplateURLData> extension_data_1 =
237 GenerateDummyTemplateURLData("ext1"); 237 GenerateDummyTemplateURLData("ext1");
238 manager.SetExtensionControlledDefaultSearchEngine(*extension_data_1); 238 SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_1);
239
240 ExpectSimilar(extension_data_1.get(), 239 ExpectSimilar(extension_data_1.get(),
241 manager.GetDefaultSearchEngine(&source)); 240 manager.GetDefaultSearchEngine(&source));
242 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source); 241 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
243 242
244 // Policy trumps extension: 243 // Policy trumps extension:
245 std::unique_ptr<TemplateURLData> policy_data = 244 std::unique_ptr<TemplateURLData> policy_data =
246 GenerateDummyTemplateURLData("policy"); 245 GenerateDummyTemplateURLData("policy");
247 SetPolicy(pref_service(), true, policy_data.get()); 246 SetPolicy(pref_service(), true, policy_data.get());
248 247
249 ExpectSimilar(policy_data.get(), manager.GetDefaultSearchEngine(&source)); 248 ExpectSimilar(policy_data.get(), manager.GetDefaultSearchEngine(&source));
250 EXPECT_EQ(DefaultSearchManager::FROM_POLICY, source); 249 EXPECT_EQ(DefaultSearchManager::FROM_POLICY, source);
251 pref_service()->RemoveManagedPref( 250 pref_service()->RemoveManagedPref(
252 DefaultSearchManager::kDefaultSearchProviderDataPrefName); 251 DefaultSearchManager::kDefaultSearchProviderDataPrefName);
253 252
254 // Extensions trump each other: 253 // Extensions trump each other:
255 std::unique_ptr<TemplateURLData> extension_data_2 = 254 std::unique_ptr<TemplateURLData> extension_data_2 =
256 GenerateDummyTemplateURLData("ext2"); 255 GenerateDummyTemplateURLData("ext2");
257 std::unique_ptr<TemplateURLData> extension_data_3 = 256 std::unique_ptr<TemplateURLData> extension_data_3 =
258 GenerateDummyTemplateURLData("ext3"); 257 GenerateDummyTemplateURLData("ext3");
259 manager.SetExtensionControlledDefaultSearchEngine(*extension_data_2);
260 manager.SetExtensionControlledDefaultSearchEngine(*extension_data_3);
261 258
259 SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_2);
260 SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_3);
262 ExpectSimilar(extension_data_3.get(), 261 ExpectSimilar(extension_data_3.get(),
263 manager.GetDefaultSearchEngine(&source)); 262 manager.GetDefaultSearchEngine(&source));
264 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source); 263 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
265 264
266 manager.ClearExtensionControlledDefaultSearchEngine(); 265 RemoveExtensionDefaultSearchFromPrefs(pref_service());
267
268 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source)); 266 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
269 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 267 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
270 } 268 }
OLDNEW
« no previous file with comments | « components/search_engines/default_search_manager.cc ('k') | components/search_engines/search_engines_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698