Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2639113002: testharnessreport: Remove isCSSWGTest() and isJSTest(). (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

testharnessreport: Remove isCSSWGTest() and isJSTest(). Some tests remove <script> from a document, and isJSTest() returned false for testharness-based tests unexpectedly. Only testharness-based tests use testharnessreport.js, so we don't need these runtime checks. BUG=681764 Review-Url: https://codereview.chromium.org/2639113002 Cr-Commit-Position: refs/heads/master@{#444314} Committed: https://chromium.googlesource.com/chromium/src/+/28efa3f1874a4f8cee744f7a1f00e6127b0b600b

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
tkent
kojii@, would you review this please?
3 years, 11 months ago (2017-01-18 05:24:25 UTC) #4
kojii
lgtm, great towards the repo merge!
3 years, 11 months ago (2017-01-18 08:46:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639113002/1
3 years, 11 months ago (2017-01-18 09:32:34 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:36:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28efa3f1874a4f8cee744f7a1f00...

Powered by Google App Engine
This is Rietveld 408576698