Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new navigation callbacks…

Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the NavigationRequest synchronously during its creation. I've added code to guard against this.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2639073002
Cr-Commit-Position: refs/heads/master@{#444377}
Committed: https://chromium.googlesource.com/chromium/src/+/9a88c6be00c8a4beb0be24791c9f6812cc78a94d

[jam, 2017-01-17 22:12:14]

Description was changed from

==========
Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new
navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new
callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm
using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the
NavigationRequest synchronously during its creation. I've added code to guard
against this.

BUG=682002
==========

to

==========
Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new
navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new
callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm
using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the
NavigationRequest synchronously during its creation. I've added code to guard
against this.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-01-17 22:12:38]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-17 22:13:20]

jam@chromium.org changed reviewers:
+ clamy@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:33:20]

Dry run: This issue passed the CQ dry run.

[clamy, 2017-01-18 14:38:28]

Thanks! Lgtm.

[jam, 2017-01-18 16:00:48]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-18 16:01:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:06:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484755248081910, "parent_rev":
"d005cbf1f2a2d8aecd221922901e7e86fc5bea5c", "commit_rev":
"9a88c6be00c8a4beb0be24791c9f6812cc78a94d"}

[commit-bot: I haz the power, 2017-01-18 16:06:48]

Description was changed from

==========
Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new
navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new
callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm
using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the
NavigationRequest synchronously during its creation. I've added code to guard
against this.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new
navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new
callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm
using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the
NavigationRequest synchronously during its creation. I've added code to guard
against this.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2639073002
Cr-Commit-Position: refs/heads/master@{#444377}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a88c6be00c8a4beb0be24791c9f...
==========

[commit-bot: I haz the power, 2017-01-18 16:06:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a88c6be00c8a4beb0be24791c9f...