Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2639013002: [wasm] Use pimpl idiom for interpreter thread implementation (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use pimpl idiom for interpreter thread implementation We used dynamic dispatch before, which has considerable runtime overhead. Pimpl (a.k.a. opaque pointer) has the same memory overhead of one additional pointer, but less runtime overhead. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2639013002 Cr-Commit-Position: refs/heads/master@{#42442} Committed: https://chromium.googlesource.com/v8/v8/+/7634b0eb13e945191c04e63af86bf9fdc1f6aa4c

Patch Set 1 #

Patch Set 2 : Fix android and windows compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -46 lines) Patch
M src/wasm/wasm-interpreter.h View 1 2 chunks +27 lines, -17 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 11 chunks +53 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (13 generated)
titzer
lgtm
3 years, 11 months ago (2017-01-18 09:53:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639013002/20001
3 years, 11 months ago (2017-01-18 10:21:45 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 10:23:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7634b0eb13e945191c04e63af86bf9fdc1f...

Powered by Google App Engine
This is Rietveld 408576698