Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2638993002: Don't delete UMA observer until after PeerConnection. (Closed)

Created:
3 years, 11 months ago by Taylor_Brandstetter
Modified:
3 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't delete UMA observer until after PeerConnection. BUG=chromium:681302 Review-Url: https://codereview.chromium.org/2638993002 Cr-Commit-Position: refs/heads/master@{#444513} Committed: https://chromium.googlesource.com/chromium/src/+/3d9dba1c2096a55778307a3d5ad322e187ab13f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor_Brandstetter
PTAL
3 years, 11 months ago (2017-01-17 19:23:42 UTC) #2
pthatcher1
lgtm
3 years, 11 months ago (2017-01-17 19:35:14 UTC) #4
perkj_chrome
lgtm
3 years, 11 months ago (2017-01-18 20:24:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638993002/1
3 years, 11 months ago (2017-01-18 21:23:26 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:26:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d9dba1c2096a55778307a3d5ad3...

Powered by Google App Engine
This is Rietveld 408576698