Add SHA1 data checksum to on-disk shader cache

Add SHA1 data checksum to on-disk shader cache

Previously, the on-disk cache was stored with a SHA1 hash of a number
of common peices of system info, such as GL Vendor, OS version, etc...

This change adds the actual data being stored to the SHA1, which should
protect against corruption on disk.

BUG=658779
Review-Url: https://codereview.chromium.org/2638933003
Cr-Commit-Position: refs/heads/master@{#444802}
Committed: https://chromium.googlesource.com/chromium/src/+/5c34fe289869ccd38b3cf39add76b00e2c51cb97

[ericrk, 2017-01-17 21:58:13]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 21:58:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ericrk, 2017-01-17 21:58:44]

ericrk@chromium.org changed reviewers:
+ jbauman@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:56:53]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-01-18 01:24:05]

https://codereview.chromium.org/2638933003/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2638933003/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:1180: if (!key.compare(0,
prefix.length(), prefix))
Could you add a UMA histogram for this?

[ericrk, 2017-01-18 19:44:16]

https://codereview.chromium.org/2638933003/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2638933003/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:1180: if (!key.compare(0,
prefix.length(), prefix))
On 2017/01/18 01:24:05, jbauman wrote:
> Could you add a UMA histogram for this?

Done.

[jbauman, 2017-01-18 23:33:37]

lgtm

[ericrk, 2017-01-18 23:35:17]

ericrk@chromium.org changed reviewers:
+ isherman@chromium.org

[ericrk, 2017-01-18 23:35:17]

+isherman for histograms.xml. Thanks!

[ericrk, 2017-01-18 23:35:26]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 02:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:01:37]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-01-19 02:08:43]

Metrics LGTM % a comment:

https://codereview.chromium.org/2638933003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2638933003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:20383: +<histogram
name="GPU.ShaderLoadPrefixOK">
Please add an enum (just in this file) with labels for the two cases, like
"didn't match" and "matched".

[ericrk, 2017-01-19 17:48:10]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-01-19 17:48:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2638933003/#ps60001
(title: "add histogram enum")

[commit-bot: I haz the power, 2017-01-19 17:48:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 18:53:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484848090338350,
"parent_rev": "113278e435c9470189456ad501a63238cec65570", "commit_rev":
"5c34fe289869ccd38b3cf39add76b00e2c51cb97"}

[commit-bot: I haz the power, 2017-01-19 18:53:46]

Description was changed from

==========
Add SHA1 data checksum to on-disk shader cache

Previously, the on-disk cache was stored with a SHA1 hash of a number
of common peices of system info, such as GL Vendor, OS version, etc...

This change adds the actual data being stored to the SHA1, which should
protect against corruption on disk.

BUG=658779
==========

to

==========
Add SHA1 data checksum to on-disk shader cache

Previously, the on-disk cache was stored with a SHA1 hash of a number
of common peices of system info, such as GL Vendor, OS version, etc...

This change adds the actual data being stored to the SHA1, which should
protect against corruption on disk.

BUG=658779

Review-Url: https://codereview.chromium.org/2638933003
Cr-Commit-Position: refs/heads/master@{#444802}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c34fe289869ccd38b3cf39add76...
==========

[commit-bot: I haz the power, 2017-01-19 18:53:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5c34fe289869ccd38b3cf39add76...

[ericrk, 2017-01-19 23:25:59]

https://codereview.chromium.org/2638933003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2638933003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:20383: +<histogram
name="GPU.ShaderLoadPrefixOK">
On 2017/01/19 02:08:43, Ilya Sherman wrote:
> Please add an enum (just in this file) with labels for the two cases, like
> "didn't match" and "matched".

There was already a BooleanMatched enum which seems appropriate. Added it to
this histogram.