objects.h splitting: Move ModuleInfoEntry

objects.h splitting: Move ModuleInfoEntry

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2638893002
Cr-Commit-Position: refs/heads/master@{#42405}
Committed: https://chromium.googlesource.com/v8/v8/+/bc35251f5e55a65c3a4acf7cba52cee505c86a46

[marja, 2017-01-17 11:39:43]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 11:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 12:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 12:07:49]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-17 12:45:15]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2017-01-17 12:45:16]

mstarzinger, ptal

[Michael Starzinger, 2017-01-17 12:55:00]

LGTM.

https://codereview.chromium.org/2638893002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2638893002/diff/1/src/objects.h#newcode11541
src/objects.h:11541: #undef DECLARE_VERIFIER
nit: Let's drop this one, it should be covered by "object-macros-undef.h" below.

[marja, 2017-01-17 12:59:47]

thanks for review

https://codereview.chromium.org/2638893002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2638893002/diff/1/src/objects.h#newcode11541
src/objects.h:11541: #undef DECLARE_VERIFIER
On 2017/01/17 12:55:00, Michael Starzinger wrote:
> nit: Let's drop this one, it should be covered by "object-macros-undef.h"
below.

Ah yes. Removed all of these.

[marja, 2017-01-17 12:59:52]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-17 12:59:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2638893002/#ps20001
(title: "dropping unnecessary undefs")

[commit-bot: I haz the power, 2017-01-17 12:59:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 13:28:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484657992395430,
"parent_rev": "0389df514d48c6394f606bf4e5b9b0b0cb134d1b", "commit_rev":
"bc35251f5e55a65c3a4acf7cba52cee505c86a46"}

[commit-bot: I haz the power, 2017-01-17 13:28:59]

Description was changed from

==========
objects.h splitting: Move ModuleInfoEntry

BUG=v8:5402
==========

to

==========
objects.h splitting: Move ModuleInfoEntry

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2638893002
Cr-Commit-Position: refs/heads/master@{#42405}
Committed:
https://chromium.googlesource.com/v8/v8/+/bc35251f5e55a65c3a4acf7cba52cee505c...
==========

[commit-bot: I haz the power, 2017-01-17 13:29:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bc35251f5e55a65c3a4acf7cba52cee505c...