macOS: Setting focus to the first profile in profile switcher

macOS: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the first
profile (other than the current one) in the list should be highlighted. This should
happens only when opening the menu with the keyboard (and not with the mouse).

BUG=674343
Review-Url: https://codereview.chromium.org/2638853003
Cr-Commit-Position: refs/heads/master@{#448586}
Committed: https://chromium.googlesource.com/chromium/src/+/eb2e0d02e494c55d5e3721fe8a70f2e4f289621f

[jlebel, 2017-01-20 12:20:53]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-01-20 12:23:03]

Description was changed from

==========
Setting focus to the first profile in profile switcher

Setting focus to the first profile in profile switcher

BUG=674343
==========

to

==========
macOS: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

BUG=674343
==========

[jlebel, 2017-01-20 12:25:16]

jlebel@chromium.org changed reviewers:
+ mark@chromium.org

[jlebel, 2017-01-20 12:25:17]

Hello Mark,

Can you review this patch about the profile switcher menu?

Thanks,

[Mark Mentovai, 2017-02-06 19:39:18]

LGTM otherwise

https://codereview.chromium.org/2638853003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/2638853003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:7: #import
<AppKit/NSEvent.h>
We don’t do this in Chrome, we just #import the top of an umbrella, like
<AppKit/AppKit.h>. But AppKit should already have come in from <Cocoa/Cocoa.h>,
so this isn’t even necessary at all.

[jlebel, 2017-02-07 10:03:27]

https://codereview.chromium.org/2638853003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/2638853003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:7: #import
<AppKit/NSEvent.h>
On 2017/02/06 19:39:18, Mark Mentovai wrote:
> We don’t do this in Chrome, we just #import the top of an umbrella, like
> <AppKit/AppKit.h>. But AppKit should already have come in from
<Cocoa/Cocoa.h>,
> so this isn’t even necessary at all.

Yes, this import is not necessary. Sorry.

[jlebel, 2017-02-07 10:03:38]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-02-07 10:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2638853003/#ps40001
(title: "Removing useless import")

[commit-bot: I haz the power, 2017-02-07 10:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 10:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486461818063500,
"parent_rev": "97d545248e030879ef49e0aebb7f9643705360b1", "commit_rev":
"eb2e0d02e494c55d5e3721fe8a70f2e4f289621f"}

[commit-bot: I haz the power, 2017-02-07 10:37:08]

Description was changed from

==========
macOS: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

BUG=674343
==========

to

==========
macOS: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

BUG=674343

Review-Url: https://codereview.chromium.org/2638853003
Cr-Commit-Position: refs/heads/master@{#448586}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb2e0d02e494c55d5e3721fe8a70...
==========

[commit-bot: I haz the power, 2017-02-07 10:37:09]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eb2e0d02e494c55d5e3721fe8a70...