Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: Source/web/WebLocalFrameImpl.h

Issue 263883004: NotificationController handles an ownership of NotificaitonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/notifications/NotificationController.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebLocalFrameImpl.h
diff --git a/Source/web/WebLocalFrameImpl.h b/Source/web/WebLocalFrameImpl.h
index cf0712d99101fc82340d56a6e6ff9125ed0e597a..63363aef0111ee0444cc5ff4da33ac8d29b535a7 100644
--- a/Source/web/WebLocalFrameImpl.h
+++ b/Source/web/WebLocalFrameImpl.h
@@ -335,7 +335,7 @@ private:
WebPlugin* focusedPluginIfInputMethodSupported();
// Returns the provider of desktop notifications.
- NotificationPresenterImpl* notificationPresenterImpl();
+ PassOwnPtr<NotificationPresenterImpl> notificationPresenterImpl();
FrameLoaderClientImpl m_frameLoaderClientImpl;
@@ -372,7 +372,7 @@ private:
float m_inputEventsScaleFactorForEmulation;
// The provider of desktop notifications;
- NotificationPresenterImpl m_notificationPresenter;
+ OwnPtr<NotificationPresenterImpl> m_notificationPresenter;
jochen (gone - plz use gerrit) 2014/05/05 07:35:14 why do you need this member now?
gyuyoung-inactive 2014/05/06 15:26:09 Yes, we don't need to keep this member and notific
UserMediaClientImpl m_userMediaClientImpl;
};
« no previous file with comments | « Source/modules/notifications/NotificationController.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698