Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2638813002: s390: remove RotLeftAndMask32 on s390 (Closed)

Created:
3 years, 11 months ago by john.yan
Modified:
3 years, 11 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: remove RotLeftAndMask32 on s390 RotleftAndMask32 is not efficient on s390 R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2638813002 Cr-Commit-Position: refs/heads/master@{#42387} Committed: https://chromium.googlesource.com/v8/v8/+/738cb6a7591465ca7039c70efc1c57ff7fa8da1d

Patch Set 1 #

Patch Set 2 : fix error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -90 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 5 chunks +2 lines, -69 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
JaideepBajwa
lgtm
3 years, 11 months ago (2017-01-16 19:01:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638813002/1
3 years, 11 months ago (2017-01-16 19:01:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638813002/20001
3 years, 11 months ago (2017-01-16 19:42:21 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 20:02:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/738cb6a7591465ca7039c70efc1c57ff7fa...

Powered by Google App Engine
This is Rietveld 408576698