Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2638803002: [heap] Remove markbits getter from raw address (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove markbits getter from raw address BUG=651354 Review-Url: https://codereview.chromium.org/2638803002 Cr-Commit-Position: refs/heads/master@{#42397} Committed: https://chromium.googlesource.com/v8/v8/+/68c994795ec8c449c2dc0991eba815ae7418af06

Patch Set 1 #

Patch Set 2 : Fix LeftTrim #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 6 chunks +14 lines, -9 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +4 lines, -7 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Michael Lippautz
3 years, 11 months ago (2017-01-16 17:17:25 UTC) #3
Hannes Payer (out of office)
lgtm
3 years, 11 months ago (2017-01-16 17:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638803002/20001
3 years, 11 months ago (2017-01-17 10:07:08 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 10:35:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/68c994795ec8c449c2dc0991eba815ae741...

Powered by Google App Engine
This is Rietveld 408576698