Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2638773003: Add missing dependency to //chrome/browser:resources (Closed)

Created:
3 years, 11 months ago by mlopatkin
Modified:
3 years, 11 months ago
Reviewers:
yzshen1, mbrunson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency to //chrome/browser:resources The browser_resources.grd file references generated uuid.mojom.js file but there was no dependency in GN files. This caused 'gn gen' with compute_grit_inputs_for_analyze=true to fail. BUG=676093 R=yzshen@chromium.org,mbrunson@chromium.org Review-Url: https://codereview.chromium.org/2638773003 Cr-Commit-Position: refs/heads/master@{#444310} Committed: https://chromium.googlesource.com/chromium/src/+/1724f97e1dc9533f2c0cd7d67a78c8b04ff78c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mlopatkin
yzshen, sorry for stealing your bug I was playing with "gn analyze" in our internal ...
3 years, 11 months ago (2017-01-16 16:30:00 UTC) #1
yzshen1
On 2017/01/16 16:30:00, mlopatkin wrote: > yzshen, sorry for stealing your bug > > I ...
3 years, 11 months ago (2017-01-17 18:17:39 UTC) #2
mbrunson
lgtm
3 years, 11 months ago (2017-01-17 18:36:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638773003/1
3 years, 11 months ago (2017-01-18 08:20:01 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:24:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1724f97e1dc9533f2c0cd7d67a78...

Powered by Google App Engine
This is Rietveld 408576698