Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2638753002: Revert of Bluetooth: macOS: BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications (Closed)

Created:
3 years, 11 months ago by pkalinnikov
Modified:
3 years, 11 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bluetooth: macOS: BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications (patchset #3 id:120001 of https://codereview.chromium.org/2599303002/ ) Reason for revert: 6 BluetoothRemoteGattCharacteristicTest's, e.g., BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged, are getting time out on "Mac10.10 Tests" and "Mac10.11 Tests" builders. Original issue's description: > Bluetooth: macOS: Replacing BluetoothRemoteGattCharacteristicMac::StartNotifySession() > by BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications(). > > BUG=633191 > > Review-Url: https://codereview.chromium.org/2599303002 > Cr-Commit-Position: refs/heads/master@{#443820} > Committed: https://chromium.googlesource.com/chromium/src/+/230ba260170c6d7ab48a72a5f0eea01be95740f3 TBR=scheib@chromium.org,fbeaufort@chromium.org,jlebel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633191 Review-Url: https://codereview.chromium.org/2638753002 Cr-Commit-Position: refs/heads/master@{#443891} Committed: https://chromium.googlesource.com/chromium/src/+/c6e9555b9c26f6c667eee3ffd471f92caa8cb196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -35 lines) Patch
M device/bluetooth/bluetooth_remote_gatt_characteristic.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h View 2 chunks +7 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 4 chunks +50 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pkalinnikov
Created Revert of Bluetooth: macOS: BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications
3 years, 11 months ago (2017-01-16 14:25:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638753002/1
3 years, 11 months ago (2017-01-16 14:26:05 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 14:28:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6e9555b9c26f6c667eee3ffd471...

Powered by Google App Engine
This is Rietveld 408576698