Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2638733002: Fix overflow in Number.prototype.toString with custom radix. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix overflow in Number.prototype.toString with custom radix. R=tebbi@chromium.org BUG=chromium:679841 Review-Url: https://codereview.chromium.org/2638733002 Cr-Commit-Position: refs/heads/master@{#42364} Committed: https://chromium.googlesource.com/v8/v8/+/73de4f8f1e89da2bb54bb3b79c58e10cf50cfd53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/conversions.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yang
3 years, 11 months ago (2017-01-16 10:54:59 UTC) #1
Tobias Tebbi
On 2017/01/16 10:54:59, Yang wrote: lgtm
3 years, 11 months ago (2017-01-16 11:40:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638733002/1
3 years, 11 months ago (2017-01-16 11:42:55 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 11:44:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/73de4f8f1e89da2bb54bb3b79c58e10cf50...

Powered by Google App Engine
This is Rietveld 408576698