Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issue 2638653008: MemoryCacheCorrectnessTest: Fix a test name typo (Closed)

Created:
3 years, 11 months ago by Takashi Toyoshima
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MemoryCacheCorrectnessTest: Fix a test name typo RequestWithNoCahe should be RequestWithNoCache. BUG=655920 TEST=ninja webkit_unit_tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Takashi Toyoshima
PTAL
3 years, 11 months ago (2017-01-17 08:37:32 UTC) #4
yhirano
lgtm
3 years, 11 months ago (2017-01-17 10:05:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638653008/1
3 years, 11 months ago (2017-01-17 10:57:42 UTC) #10
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-17 11:06:24 UTC) #13
Takashi Toyoshima
3 years, 11 months ago (2017-01-17 11:17:19 UTC) #14
Manually checked.
This was submitted correctly.

commit 17d77116e97bade618e29ce717c26ed88e439dc7
Author: toyoshim <toyoshim@chromium.org>
Date:   Tue Jan 17 03:01:23 2017 -0800

    MemoryCacheCorrectnessTest: Fix a test name typo

    RequestWithNoCahe should be RequestWithNoCache.

    BUG=655920
    TEST=ninja webkit_unit_tests

    Review-Url: https://codereview.chromium.org/2638653008
    Cr-Commit-Position: refs/heads/master@{#444020}

Powered by Google App Engine
This is Rietveld 408576698