Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2638653005: android: Record the source of account change notifications from GSA. (Closed)

Created:
3 years, 11 months ago by Benoit L
Modified:
3 years, 11 months ago
Reviewers:
Ted C, Yusuf, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Record the source of account change notifications from GSA. GSA can notify Chrome of an account change through either a service call, or through a broadcast. This histogram records the number of account changes of each type that Chrome sees. This is intended to act as a migration tracker and sanity check as we migrate from the service to the broadcast mechanism. The total count should stay approximately the same, while the proportion of each type changes. BUG=614388 Review-Url: https://codereview.chromium.org/2638653005 Cr-Commit-Position: refs/heads/master@{#444705} Committed: https://chromium.googlesource.com/chromium/src/+/f8e7b55cbaf9147033f46e730a029347d3ae5baa

Patch Set 1 #

Patch Set 2 : Add OWNERS file, per tedchoc's suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListener.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/gsa/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Benoit L
3 years, 11 months ago (2017-01-16 14:54:50 UTC) #4
Yusuf
lgtm
3 years, 11 months ago (2017-01-17 07:45:42 UTC) #7
Benoit L
+isherman for the historgram part. PTAL, thanks :-)
3 years, 11 months ago (2017-01-17 10:36:25 UTC) #9
Ilya Sherman
Metrics LGTM
3 years, 11 months ago (2017-01-18 02:15:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638653005/1
3 years, 11 months ago (2017-01-18 09:40:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/344040)
3 years, 11 months ago (2017-01-18 09:47:03 UTC) #14
Benoit L
+tedchoc for owners approval. Thanks!
3 years, 11 months ago (2017-01-18 09:56:15 UTC) #16
Ted C
On 2017/01/18 09:56:15, Benoit L wrote: > +tedchoc for owners approval. > Thanks! lgtm -- ...
3 years, 11 months ago (2017-01-18 18:23:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638653005/20001
3 years, 11 months ago (2017-01-19 09:45:14 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 10:58:39 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8e7b55cbaf9147033f46e730a02...

Powered by Google App Engine
This is Rietveld 408576698