Allow pausing paused animations for testing

Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
removes the assertion.

BUG=681321
Review-Url: https://codereview.chromium.org/2638593003
Cr-Commit-Position: refs/heads/master@{#443981}
Committed: https://chromium.googlesource.com/chromium/src/+/922804de065e29779f3b562e4d7e81fb7648836b

[alancutter (OOO until 2018), 2017-01-16 05:51:41]

Description was changed from

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
lowers the assertion down to pauseForTesting() should only be called
once.

BUG=681321
==========

to

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
lowers the assertion down to "pauseForTesting() should only be called
once".

BUG=681321
==========

[alancutter (OOO until 2018), 2017-01-16 05:51:41]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[alancutter (OOO until 2018), 2017-01-16 05:51:57]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 05:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 07:34:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 07:34:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2017-01-16 22:31:48]

Not crashing is good! lgtm
But why do we need to limit pauseForTesting to being called once at all?

[alancutter (OOO until 2018), 2017-01-17 01:59:18]

On 2017/01/16 at 22:31:48, suzyh wrote:
> Not crashing is good! lgtm
> But why do we need to limit pauseForTesting to being called once at all?

I guess we don't and judging by the failing tests it's not a thing to be
expected anyway!

[alancutter (OOO until 2018), 2017-01-17 01:59:55]

Description was changed from

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
lowers the assertion down to "pauseForTesting() should only be called
once".

BUG=681321
==========

to

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
removes the assertion.

BUG=681321
==========

[alancutter (OOO until 2018), 2017-01-17 02:00:16]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-17 02:00:17]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2638593003/#ps20001
(title: "Remove check")

[commit-bot: I haz the power, 2017-01-17 02:00:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 03:40:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484618416950760,
"parent_rev": "38cfdb247bfbe1d7438173ce3cf46e19394ca53e", "commit_rev":
"922804de065e29779f3b562e4d7e81fb7648836b"}

[commit-bot: I haz the power, 2017-01-17 03:40:45]

Description was changed from

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
removes the assertion.

BUG=681321
==========

to

==========
Allow pausing paused animations for testing

The Animation::pauseForTesting() method asserts that it is not already
paused. There's no real reason not to allow this scenario so this patch
removes the assertion.

BUG=681321

Review-Url: https://codereview.chromium.org/2638593003
Cr-Commit-Position: refs/heads/master@{#443981}
Committed:
https://chromium.googlesource.com/chromium/src/+/922804de065e29779f3b562e4d7e...
==========

[commit-bot: I haz the power, 2017-01-17 03:40:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/922804de065e29779f3b562e4d7e...