Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2638473003: S390: fix to use the correct cmp macro function (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: fix to use the correct cmp macro function This issue was exposed with snapshot=off R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=n Review-Url: https://codereview.chromium.org/2638473003 Cr-Commit-Position: refs/heads/master@{#42346} Committed: https://chromium.googlesource.com/v8/v8/+/8b1303ab91d3e4ad3e754785d480879aa9840fae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/s390/macro-assembler-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-14 00:25:41 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-14 00:26:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638473003/1
3 years, 11 months ago (2017-01-14 00:26:41 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 00:53:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8b1303ab91d3e4ad3e754785d480879aa98...

Powered by Google App Engine
This is Rietveld 408576698