Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: components/crash/content/app/fallback_crash_handler_launcher_win.cc

Issue 2638433002: Integrate fallback crash handling in chrome (Closed)
Patch Set: Fix signedness comparison goof. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/fallback_crash_handler_launcher_win.cc
diff --git a/components/crash/content/app/fallback_crash_handler_launcher_win.cc b/components/crash/content/app/fallback_crash_handler_launcher_win.cc
index 1fa06036682401560cbbc727aa6b57fde7a84905..45c8c83db29d6894031d6d56931597500acda279 100644
--- a/components/crash/content/app/fallback_crash_handler_launcher_win.cc
+++ b/components/crash/content/app/fallback_crash_handler_launcher_win.cc
@@ -28,8 +28,8 @@ bool FallbackCrashHandlerLauncher::Initialize(
const base::CommandLine& program,
const base::FilePath& crashpad_database) {
// Open an inheritable handle to self. This will be inherited to the handler.
- const DWORD kAccessMask =
- PROCESS_QUERY_INFORMATION | PROCESS_VM_READ | PROCESS_DUP_HANDLE;
+ const DWORD kAccessMask = PROCESS_QUERY_INFORMATION | PROCESS_VM_READ |
+ PROCESS_DUP_HANDLE | PROCESS_TERMINATE;
self_process_handle_.Set(
OpenProcess(kAccessMask, TRUE, ::GetCurrentProcessId()));
if (!self_process_handle_.IsValid())

Powered by Google App Engine
This is Rietveld 408576698