Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/crash/content/app/BUILD.gn

Issue 2638433002: Integrate fallback crash handling in chrome (Closed)
Patch Set: Fix signedness comparison goof. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/BUILD.gn
diff --git a/components/crash/content/app/BUILD.gn b/components/crash/content/app/BUILD.gn
index 23255030fa61386082044dcbf42baaa1155c26d4..0cf0c6ca109e31b8559d002c92a73d1c2d5d5e82 100644
--- a/components/crash/content/app/BUILD.gn
+++ b/components/crash/content/app/BUILD.gn
@@ -70,12 +70,15 @@ if (is_win) {
"fallback_crash_handler_launcher_win.h",
"fallback_crash_handler_win.cc",
"fallback_crash_handler_win.h",
+ "fallback_crash_handling_win.cc",
+ "fallback_crash_handling_win.h",
"run_as_crashpad_handler_win.cc",
"run_as_crashpad_handler_win.h",
]
deps = [
"//base",
+ "//chrome/install_static:install_static_util",
brettw 2017/08/24 23:35:46 This is a layering violation. Can you please fix i
Sigurður Ásgeirsson 2017/08/25 20:20:55 Done.
"//third_party/crashpad/crashpad/client",
"//third_party/crashpad/crashpad/handler:handler_lib",
"//third_party/crashpad/crashpad/minidump",
@@ -221,6 +224,7 @@ source_set("unit_tests") {
"crash_keys_win_unittest.cc",
"fallback_crash_handler_launcher_win_unittest.cc",
"fallback_crash_handler_win_unittest.cc",
+ "fallback_crash_handling_win_unittest.cc",
]
deps = [
":lib",

Powered by Google App Engine
This is Rietveld 408576698