Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2638433002: Integrate fallback crash handling in chrome (Closed)
Patch Set: Fix signedness comparison goof. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | components/crash/content/app/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index b13781d981b37f35d6522d1b62b6b47c1cc19350..ca4f18bccf7acb1995af95f4e3e34a67deb4ffc8 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -254,7 +254,10 @@ void ChromeCrashReporterClient::InitializeCrashReportingForProcess() {
std::wstring process_type = install_static::GetSwitchValueFromCommandLine(
::GetCommandLine(), install_static::kProcessType);
- if (process_type != install_static::kCrashpadHandler) {
+ // Don't set up Crashpad crash reporting in the Crashpad handler itself, nor
+ // in the fallback crash handler for the Crashpad handler process.
+ if (process_type != install_static::kCrashpadHandler &&
+ process_type != install_static::kFallbackHandler) {
crash_reporter::SetCrashReporterClient(instance);
crash_reporter::InitializeCrashpadWithEmbeddedHandler(
process_type.empty(), install_static::UTF16ToUTF8(process_type));
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | components/crash/content/app/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698